Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp2592807ybz; Mon, 27 Apr 2020 00:05:32 -0700 (PDT) X-Google-Smtp-Source: APiQypL5b0y1EjLlCQr+R0ml8BkaqZVz4r5aFKcu1kVHDy3YKbUJH03ARV9+0hifRpxMpEqJVlXI X-Received: by 2002:a17:906:315a:: with SMTP id e26mr18146145eje.53.1587971131866; Mon, 27 Apr 2020 00:05:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587971131; cv=none; d=google.com; s=arc-20160816; b=HaB+UEWiABUq86wxpMB6i7hmdIZW+6PDgHI7dO5P1BbYEmLhWBhWi8174DTZvMiuhW +MPZbMS7l4ejEzTD162axtY/SbSEZMA+SVT1FCnLSDP6Mf6wXRzhn+GjfEa8Fw/fuvyS TR+qHOYW/Og5tO0z15dKbIAXCiMvEmp3EW59WhYloH6KiYh+auYpFCr95LrmcflvCMNE gdvHxmaBquJu6FaqTW4O4Yrr8h3Xg5xhRaDHcexYjqV9aZy3TqQm+vXPwMjMvO4ct/8L ueO0FThM+W0lifYWIPMFGoZpKvsB81cp/fZWJHHqTwfLsuFYxfpqVBBr58KGSABLQHX6 q77w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from; bh=Sl3K83gOo2glucJZFuWDFWcpJORS1AP2wRLAwLuSX0M=; b=YhSSTFAVQOjvxmvUsBjSHVE94IYiChXVEpgLGhiQKp9BWuHy3bPGSB6NZ0gyyiFcXa a21dBKnb0JztwYx6wN5nH8tz2j0LdM6gp5GPUmto0qNeFWse2UcD5kKlNbRMPw3eLDng 2KH9XsXBlqYbnuTaZWJXQfrenoW6MDVdqeoag5ra2FM1uYO1dg6hrLVjssrYWtKXUAQd UMg0XQzplfQrEKZ+ruJam8cUATsPUUgLDcSQa1PX6/Ju/wZH2Akis29mLc5wDNxPLj1q Ap6cFtKcsa2B5U7Rphm0QBWkjz775LhBi52fy63ojskww7Xm2q9BmKByCg7/Qo+g1FYV Nd3g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o3si8111141edb.156.2020.04.27.00.05.07; Mon, 27 Apr 2020 00:05:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726691AbgD0HDk (ORCPT + 99 others); Mon, 27 Apr 2020 03:03:40 -0400 Received: from out30-54.freemail.mail.aliyun.com ([115.124.30.54]:57169 "EHLO out30-54.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726589AbgD0HDj (ORCPT ); Mon, 27 Apr 2020 03:03:39 -0400 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R971e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01f04397;MF=alex.shi@linux.alibaba.com;NM=1;PH=DS;RN=19;SR=0;TI=SMTPD_---0TwlGiqm_1587971015; Received: from localhost(mailfrom:alex.shi@linux.alibaba.com fp:SMTPD_---0TwlGiqm_1587971015) by smtp.aliyun-inc.com(127.0.0.1); Mon, 27 Apr 2020 15:03:36 +0800 From: Alex Shi To: akpm@linux-foundation.org, mgorman@techsingularity.net, tj@kernel.org, hughd@google.com, khlebnikov@yandex-team.ru, daniel.m.jordan@oracle.com, yang.shi@linux.alibaba.com, willy@infradead.org, hannes@cmpxchg.org, lkp@intel.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, shakeelb@google.com, iamjoonsoo.kim@lge.com, richard.weiyang@gmail.com Cc: Alex Shi , Michal Hocko , Vladimir Davydov Subject: [PATCH v10 07/15] mm/memcg: add debug checking in lock_page_memcg Date: Mon, 27 Apr 2020 15:02:56 +0800 Message-Id: <1587970985-21629-8-git-send-email-alex.shi@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1587970985-21629-1-git-send-email-alex.shi@linux.alibaba.com> References: <1587970985-21629-1-git-send-email-alex.shi@linux.alibaba.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Add a debug checking in lock_page_memcg, then we could get alarm if anything wrong here. Suggested-by: Johannes Weiner Signed-off-by: Alex Shi Cc: Johannes Weiner Cc: Michal Hocko Cc: Vladimir Davydov Cc: Andrew Morton Cc: cgroups@vger.kernel.org Cc: linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org --- mm/memcontrol.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/mm/memcontrol.c b/mm/memcontrol.c index 7b63260c9b57..9184d9215cf2 100644 --- a/mm/memcontrol.c +++ b/mm/memcontrol.c @@ -1979,6 +1979,12 @@ struct mem_cgroup *lock_page_memcg(struct page *page) if (unlikely(!memcg)) return NULL; +#ifdef CONFIG_PROVE_LOCKING + local_irq_save(flags); + might_lock(&memcg->move_lock); + local_irq_restore(flags); +#endif + if (atomic_read(&memcg->moving_account) <= 0) return memcg; -- 1.8.3.1