Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Jose Abreu <Jose.Abreu@synopsys.com>
To:     Christoph Hellwig <hch@infradead.org>
CC:     "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        Joao Pinto <Joao.Pinto@synopsys.com>,
        Joao Lima <Joao.Lima@synopsys.com>,
        Alim Akhtar <alim.akhtar@samsung.com>,
        Avri Altman <avri.altman@wdc.com>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 1/5] scsi: ufs: Allow UFS 3.0 as a valid version
Thread-Topic: [PATCH 1/5] scsi: ufs: Allow UFS 3.0 as a valid version
Thread-Index: AQHWGizK1kUc/ISWPkaEfUWaN7uIfKiJsAgAgALsH5A=
Date:   Mon, 27 Apr 2020 07:50:32 +0000
Message-ID: <BN8PR12MB3266F56D240A7BF0FC82B5B8D3AF0@BN8PR12MB3266.namprd12.prod.outlook.com>
References: <cover.1587727756.git.Jose.Abreu@synopsys.com>
 <5c4281080538b74ca39cedb9112ffe71bf7a80b5.1587727756.git.Jose.Abreu@synopsys.com>
 <20200425111056.GA3384@infradead.org>
In-Reply-To: <20200425111056.GA3384@infradead.org>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: synopsys.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 5ca30708-5687-4f18-c4b4-08d7ea7fa9e3
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Apr 2020 07:50:32.7237
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: c33c9f88-1eb7-4099-9700-16013fd9e8aa
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: HG5qToh+K3uN0BzBZJmxwK4y9qLeQUvOmWRR/a3UXc4UrIAyG4zwH3PVeAD8W0eoemZhy5tQiW6QaK7ffM2eaA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR12MB3089
X-OriginatorOrg: synopsys.com
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Christoph Hellwig <hch@infradead.org>
Date: Apr/25/2020, 12:10:56 (UTC+00:00)

> On Fri, Apr 24, 2020 at 01:36:56PM +0200, Jose Abreu wrote:
> > Add a define for UFS version 3.0 and do not print an error message upon
> > probe when using this version.
>=20
> This doesn't really scale.  Version checks only make sense for a minimum
> supported version.  Rejecting newer versions is just a bad idea.
>=20
> > @@ -8441,7 +8441,8 @@ int ufshcd_init(struct ufs_hba *hba, void __iomem=
 *mmio_base, unsigned int irq)
> >  	if ((hba->ufs_version !=3D UFSHCI_VERSION_10) &&
> >  	    (hba->ufs_version !=3D UFSHCI_VERSION_11) &&
> >  	    (hba->ufs_version !=3D UFSHCI_VERSION_20) &&
> > -	    (hba->ufs_version !=3D UFSHCI_VERSION_21))
> > +	    (hba->ufs_version !=3D UFSHCI_VERSION_21) &&
> > +	    (hba->ufs_version !=3D UFSHCI_VERSION_30))
>=20
> i.e. this should become
>=20
> 	if (hba->ufs_version < UFSHCI_VERSION_10)
>=20
> as an additional cleanup I think it makes more sense t use a UFSHCI_VER()
> macro similar to KERNEL_VERSION() or NVME_VS() instead of adding a new
> define for every version.

Yeah, unfortunately I don't think this can be done because of this:

enum {
	UFSHCI_VERSION_10 =3D 0x00010000, /* 1.0 */
	UFSHCI_VERSION_11 =3D 0x00010100, /* 1.1 */
	UFSHCI_VERSION_20 =3D 0x00000200, /* 2.0 */
	UFSHCI_VERSION_21 =3D 0x00000210, /* 2.1 */
};

So, version 1.0 and 1.1 have higher values of 2.0 and 2.1 in terms of=20
absolute value.

---
Thanks,
Jose Miguel Abreu