Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] drm/amd/display: remove conversion to bool in
 dc_link_ddc.c
To:     Jason Yan <yanaijie@huawei.com>, harry.wentland@amd.com,
        sunpeng.li@amd.com, alexander.deucher@amd.com, David1.Zhou@amd.com,
        airlied@linux.ie, daniel@ffwll.ch, amd-gfx@lists.freedesktop.org,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
References: <20200427063726.21363-1-yanaijie@huawei.com>
From:   =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
Message-ID: <d7546d27-a17f-8dcd-c396-79476a3972c1@amd.com>
Date:   Mon, 27 Apr 2020 10:03:23 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.9.0
In-Reply-To: <20200427063726.21363-1-yanaijie@huawei.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from [IPv6:2a02:908:1252:fb60:be8a:bd56:1f94:86e7] (2a02:908:1252:fb60:be8a:bd56:1f94:86e7) by AM0PR05CA0083.eurprd05.prod.outlook.com (2603:10a6:208:136::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2937.13 via Frontend Transport; Mon, 27 Apr 2020 08:03:28 +0000
X-Originating-IP: [2a02:908:1252:fb60:be8a:bd56:1f94:86e7]
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-HT: Tenant
X-MS-Office365-Filtering-Correlation-Id: 94ddf153-171c-4a47-8eb2-08d7ea817942
X-MS-TrafficTypeDiagnostic: DM6PR12MB4564:|DM6PR12MB4564:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <DM6PR12MB4564C32B4AC4D0B0D16C0F1783AF0@DM6PR12MB4564.namprd12.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:1923;
X-Forefront-PRVS: 0386B406AA
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR12MB4401.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(396003)(136003)(39860400002)(346002)(366004)(376002)(81156014)(6486002)(31696002)(8676002)(8936002)(2906002)(66574012)(36756003)(86362001)(316002)(6666004)(31686004)(2616005)(186003)(5660300002)(16526019)(66476007)(52116002)(478600001)(66946007)(66556008)(921003);DIR:OUT;SFP:1101;
Received-SPF: None (protection.outlook.com: amd.com does not designate
 permitted sender hosts)
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 8A9n2qtL/UNZYLxGc1cbOOFgpXB6ln12RBQc302TYu6vzO4W6zKL4eUQjJtJ0krckhK4rzAdacKWJnSp5u9i8/Ocp6/Auo6NffKZ8Bg7TUTnL/0cBuVE9gsRmbDMfz21Pxbigs14IID8DgSIP9Qoqzkea74K/wIAfEOC1TPNiKIY8ypUBeGLZxFzxCfUHvSxseFcPJTkGhPYL3p1spWxXBlDfXF7CFsij+u886wDEZK2RVr21eL4iPijojzf9FA0PCBLCPCNpyF6rjl0YkyQZ9AX4zR1Nh8PPTbpAJs4U0BdlttL2JhUfMxCjzgjiar8Kg7s8RAK0GGbDzD2nH1Sk7LTGmrIKYbFVEzDptglexvfSMFi009FWx3WsG8CBdjGp2arLlo175+kza21aiCCMSrKxKLISHfJPB3uS6FjPzhAwtjiv7gdRVd8xzSkLFNkVFsbh1HDmjOEuEJaiCObEWxG3oM4Ec7cFBEluFnN8Vc=
X-MS-Exchange-AntiSpam-MessageData: YN9SriQVKpha0XN/7+/INhEN/ili7MSWG04091jWZPDbsYi5Zebc0zysIz7avvWNa5EBeUQnQVK/mcU+xdOKgpcAjmpe1RRF5APQNlS/crtO9j3g4pp65WnDy+R/mxzEGZuFX5ZYfddZWEWkQwqA1iT3N5uPGKTzPaDISLPiNsOUz5ZkhfmOLfw7qswTEByq8dyky6ciw+xJ1s8SXs8ZO7A7l2n/uT5zNHdXdokKFc4P2ZhHbJoIoFnq9ZFQ8xc19+W3fAvxEs8shEG9jKEPZxPzlCJeLNg0JNIBPoZmgYzHDTQgoldeT3EcZZJkslM0kdlJ3L9pw4ZAoyBgJz0zhJO92Bxi6Fq9ulGMD79IeXhy1TkMn/uT9rL177R3RKNZDCpuYjcRol1THMF1Dy7OEsWcJvkftuDbiuRAi8DXLp2TUw0TxrdAC0QpTN3kOLT2/M0YNFGcDA+K3JC6LeGLM/RE2F52tl9DGUyNm1m3HNdvNpkknZKBleBYl2ie1xB7RPXOmeF8oHHj7BWG9eHsu8D3I15ssNfcOCRvswoSYv3ikCN6MHZbB9pQIqrYk0JSp3QhP3sxvPVF1pOEy/DQavmb0dn7JIUz0jxHvfh7HYVBz6L4eghocotHu2bxV/lJwE1B+6Td80NnkNBVzimtqmjq9vmhAfV9Sl1G4PPjU6h4QlrzAbvpOKXCWwtTGFE/KH0mtR816po7nH3F/c1FUUssXn0e4yOc1ojMniNHzu9BWEE6uCsw6272Vf9A4+ExziC0kYFJU/wHUdD0QR6Nd8465Vk6BdUknKhhJobT8GPY/8rAHy4rLgouiDLfWsUupbZI+3CzU5Ct6CexuUV0XJB5ir70DidfrjiOu3k1GA0=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 94ddf153-171c-4a47-8eb2-08d7ea817942
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Apr 2020 08:03:30.3793
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: NRi7ArVtqAvv+y3iujiNfwU/oD/OsvguhTfr3mdxpPz1L42NMg0AOWSDlSpOQnym
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4564
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am 27.04.20 um 08:37 schrieb Jason Yan:
> The '>' expression itself is bool, no need to convert it to bool again.
> This fixes the following coccicheck warning:
>
> drivers/gpu/drm/amd/display/dc/core/dc_link_ddc.c:602:28-33: WARNING:
> conversion to bool not needed here
>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>

Reviewed-by: Christian König <christian.koenig@amd.com>

> ---
>   drivers/gpu/drm/amd/display/dc/core/dc_link_ddc.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link_ddc.c b/drivers/gpu/drm/amd/display/dc/core/dc_link_ddc.c
> index 256889eed93e..aefd29a440b5 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc_link_ddc.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc_link_ddc.c
> @@ -599,7 +599,7 @@ bool dal_ddc_submit_aux_command(struct ddc_service *ddc,
>   	do {
>   		struct aux_payload current_payload;
>   		bool is_end_of_payload = (retrieved + DEFAULT_AUX_MAX_DATA_SIZE) >
> -			payload->length ? true : false;
> +			payload->length;
>   
>   		current_payload.address = payload->address;
>   		current_payload.data = &payload->data[retrieved];