Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <1587966099-28139-1-git-send-email-hadar.gat@arm.com>
 <1587966099-28139-3-git-send-email-hadar.gat@arm.com> <CAMj1kXGwVZiGbsT2NwWTyka0FVZnQcmfMSeoBKD03PdC=fRZeA@mail.gmail.com>
 <DB6PR0802MB25334429B7DD333780E7BABBE9AF0@DB6PR0802MB2533.eurprd08.prod.outlook.com>
In-Reply-To: <DB6PR0802MB25334429B7DD333780E7BABBE9AF0@DB6PR0802MB2533.eurprd08.prod.outlook.com>
From:   Arnd Bergmann <arnd@arndb.de>
Date:   Mon, 27 Apr 2020 10:19:28 +0200
Message-ID: <CAK8P3a1LYAESnePbwbn7x7x=2MCTWUNZVmmoiuv+_-J2ntFGmA@mail.gmail.com>
Subject: Re: [PATCH 2/3] hwrng: cctrng - change default to n
To:     Hadar Gat <Hadar.Gat@arm.com>
Cc:     Ard Biesheuvel <ardb@kernel.org>, Matt Mackall <mpm@selenic.com>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Krzysztof Kozlowski <krzk@kernel.org>,
        Stefan Wahren <wahrenst@gmx.net>,
        Zaibo Xu <xuzaibo@huawei.com>,
        Tomer Maimon <tmaimon77@gmail.com>,
        Randy Dunlap <rdunlap@infradead.org>,
        Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Gilad Ben-Yossef <gilad@benyossef.com>,
        Ofir Drang <Ofir.Drang@arm.com>, nd <nd@arm.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Apr 27, 2020 at 9:26 AM Hadar Gat <Hadar.Gat@arm.com> wrote:
> > -----Original Message-----
> > From: Ard Biesheuvel <ardb@kernel.org>
> > > +       default n
> >
> > 'default n' is the default so you can just remove the line
>
> Is this a guideline or just optional?
> Personally I like things to be explicit and if allowed I prefer to keep this line.

It's a common convention, and we have had patches in the past that
mass-removed those lines. I'd also just leave it out. It is generally well
understood that all options default to 'n' unless specified otherwise.

        Arnd