Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Yash Shah <yash.shah@sifive.com>
To:     Dejin Zheng <zhengdejin5@gmail.com>,
        "davem@davemloft.net" <davem@davemloft.net>,
        Paul Walmsley <paul.walmsley@sifive.com>,
        "palmer@dabbelt.com" <palmer@dabbelt.com>,
        "nicolas.ferre@microchip.com" <nicolas.ferre@microchip.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Andy Shevchenko <andy.shevchenko@gmail.com>
Subject: RE: [PATCH net v1] net: macb: fix an issue about leak related system
 resources
Thread-Topic: [PATCH net v1] net: macb: fix an issue about leak related system
 resources
Thread-Index: AQHWGwEgfqTJAKgECUicL9uwKoHGBqiMpFLw
Date:   Mon, 27 Apr 2020 08:25:41 +0000
Message-ID: <MN2PR13MB355263F89012F7D742DAE5FA8CAF0@MN2PR13MB3552.namprd13.prod.outlook.com>
References: <20200425125737.5245-1-zhengdejin5@gmail.com>
In-Reply-To: <20200425125737.5245-1-zhengdejin5@gmail.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: sifive.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: e14d683b-d13b-4ad4-87f1-08d7ea849393
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Apr 2020 08:25:42.5298
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 22f88e9d-ae0d-4ed9-b984-cdc9be1529f1
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: cX74N57vdGxpgQ9I4jvk/pap/vjL+GWduhT6BlLl5zThatH1eQXodZRZcuC4k6gGJmaiGnLr0cyFgoxVQ3eT2g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR13MB3309
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> -----Original Message-----
> From: Dejin Zheng <zhengdejin5@gmail.com>
> Sent: 25 April 2020 18:28
> To: davem@davemloft.net; Paul Walmsley <paul.walmsley@sifive.com>;
> palmer@dabbelt.com; nicolas.ferre@microchip.com; Yash Shah
> <yash.shah@sifive.com>; netdev@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org; Dejin Zheng <zhengdejin5@gmail.com>;
> Andy Shevchenko <andy.shevchenko@gmail.com>
> Subject: [PATCH net v1] net: macb: fix an issue about leak related system
> resources
>=20
> [External Email] Do not click links or attachments unless you recognize t=
he
> sender and know the content is safe
>=20
> A call of the function macb_init() can fail in the function fu540_c000_in=
it. The
> related system resources were not released then. use devm_ioremap() to
> replace ioremap() for fix it.
>=20
> Fixes: c218ad559020ff9 ("macb: Add support for SiFive FU540-C000")
> Cc: Andy Shevchenko <andy.shevchenko@gmail.com>
> Signed-off-by: Dejin Zheng <zhengdejin5@gmail.com>
> ---
>  drivers/net/ethernet/cadence/macb_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/net/ethernet/cadence/macb_main.c
> b/drivers/net/ethernet/cadence/macb_main.c
> index a0e8c5bbabc0..edba2eb56231 100644
> --- a/drivers/net/ethernet/cadence/macb_main.c
> +++ b/drivers/net/ethernet/cadence/macb_main.c
> @@ -4178,7 +4178,7 @@ static int fu540_c000_init(struct platform_device
> *pdev)
>         if (!res)
>                 return -ENODEV;
>=20
> -       mgmt->reg =3D ioremap(res->start, resource_size(res));
> +       mgmt->reg =3D devm_ioremap(&pdev->dev, res->start,
> + resource_size(res));
>         if (!mgmt->reg)
>                 return -ENOMEM;
>=20
> --
> 2.25.0

The change looks good to me.
Reviewed-by: Yash Shah <yash.shah@sifive.com>

- Yash