Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751933AbWCFQfr (ORCPT ); Mon, 6 Mar 2006 11:35:47 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751914AbWCFQfn (ORCPT ); Mon, 6 Mar 2006 11:35:43 -0500 Received: from gprs189-60.eurotel.cz ([160.218.189.60]:14311 "EHLO amd.ucw.cz") by vger.kernel.org with ESMTP id S1751867AbWCFQfX (ORCPT ); Mon, 6 Mar 2006 11:35:23 -0500 Date: Mon, 6 Mar 2006 12:56:07 +0100 From: Pavel Machek To: Richard Purdie Cc: Andrew Morton , lenz@cs.wisc.edu, kernel list , Russell King Subject: Re: [patch] fix hardcoded values in collie frontlight Message-ID: <20060306115607.GA28908@elf.ucw.cz> References: <20060305142859.GA21173@elf.ucw.cz> <1141587964.6521.55.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1141587964.6521.55.camel@localhost.localdomain> X-Warning: Reading this can be dangerous to your mental health. User-Agent: Mutt/1.5.9i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 721 Lines: 26 > > @@ -93,11 +94,13 @@ void locomolcd_power(int on) > > } > > > > /* read comadj */ > > + if (comadj == -1) { > > #ifdef CONFIG_MACH_POODLE > > - comadj = 118; > > + comadj = 118; > > #else > > - comadj = 128; > > + comadj = 128; > > #endif > > + } > > Perhaps use machine_is_poodle() and machine_is_collie() here? Yep, and unneccesssary includes can be killed. Thanks. Pavel -- Web maintainer for suspend.sf.net (www.sf.net/projects/suspend) wanted... - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/