Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp2732731ybz; Mon, 27 Apr 2020 03:33:53 -0700 (PDT) X-Google-Smtp-Source: APiQypIT5OdYb1l8ThUyz12SiCUhn3jNxEQe2BLeCbYSZQQV9/rILr6K+kbglJFwcgf0ppLpB4cu X-Received: by 2002:a50:9b0f:: with SMTP id o15mr18319673edi.325.1587983633634; Mon, 27 Apr 2020 03:33:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587983633; cv=none; d=google.com; s=arc-20160816; b=VFpmMLtlpf6GMO4d/ppCGAvgcJ+ZVsLhAl+YQr3RTfCTFuIyVpPuphysuqsywCvS5x AQCf4bRHzcnOIQT/QT8NcB9FMFF9eDE8dYtcv19eCq5baMeBFnOQXnL6OAZaj9MKozHn 4jSJDbA3cX2QODChRiziUHw2KNmYsAWaay9d8EqwZv4MfXse//cA46xUBbBETT/YuQrX HaE3Ygbxvqm80j6DFyjsYkn9frKO1u9Kj4cirGAMy9mZ+AVwyEwOeTAxcODNfauIn0kM d1w0r4rwZ+xzwgYduhlZt6767O3n70FCPETQdgOp4sz8X0mF5lyaowx6PwbzT6VSar5G /d/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=a7Zp9jkUZril10pkTuWEdWoW1stBLOxbU7AgokxOr3w=; b=MrqkKoO2Z8EInABdwEKZtilZ2ggVU92LNu41MhBQShk7GLJQPQgLvP/v49EKdHBeiE 92GoukgVfIWq4RlzkxRpvD91EhU7LMnvvXDsHrDL9COQUqlYAwfRYF4caTlp/oNt19En evTVs4Tzj8fw8M1W1NENESWf+FnKNzM0HCcUCuyE7U5hRJlMavYPnmtSJ8BESBGT0kDS w90fc4vRyAIqmGFQlLOtHyks/t70tR8WBiHGyK5QC8+cUe0k2nGWEGozIz+OS01p2CAr amrTyuPqA5p+AHC9RD82/sg/cz3OHGrsO/bkd+9S7n9SnQ4VbAPH0oV1qyqJoBVut/Uf EW5Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m29si7748205eda.592.2020.04.27.03.33.30; Mon, 27 Apr 2020 03:33:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727083AbgD0K3R (ORCPT + 99 others); Mon, 27 Apr 2020 06:29:17 -0400 Received: from foss.arm.com ([217.140.110.172]:33302 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727036AbgD0K3Q (ORCPT ); Mon, 27 Apr 2020 06:29:16 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 94D601FB; Mon, 27 Apr 2020 03:29:15 -0700 (PDT) Received: from e107158-lin (e107158-lin.cambridge.arm.com [10.1.195.21]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2BD5F3F68F; Mon, 27 Apr 2020 03:29:14 -0700 (PDT) Date: Mon, 27 Apr 2020 11:29:11 +0100 From: Qais Yousef To: "Rafael J. Wysocki" Cc: Thomas Gleixner , Len Brown , Pavel Machek , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , x86@kernel.org, Todd E Brandt , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] Revert "cpu/hotplug: Ignore pm_wakeup_pending() for disable_nonboot_cpus()" Message-ID: <20200427102910.b6iysyumiz5pj4sv@e107158-lin> References: <20200409112742.3581-1-qais.yousef@arm.com> <26038947.HFycnDbHsR@kreacher> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <26038947.HFycnDbHsR@kreacher> User-Agent: NeoMutt/20171215 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/26/20 17:24, Rafael J. Wysocki wrote: > I would do this the other way around: > > 1. Make x86 call freeze_secondary_cpus() directly, rename > enable_nonboot_cpus() and drop disable_nonboot_cpus(). All of this in a single patch? > 2. Get rid of __freeze_secondary_cpus(). I guess you're implying to drop the revert too and manually unroll it instead. Could do. Thanks -- Qais Yousef