Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: gq+ZXT1esErZxXnN2882pCdbo7+xEWANqlu3NWaBWe6/8GBZX2e4FLYD9yTEOVGWiAi6Ye3fQh
 K/nFmBX6npWg==
IronPort-SDR: MWGPKE2LfyupxpqM1+pDGLkX2OftspcC8m2J3vn7tkq7q2JkA04hpyxaogOBIZP6x4OOVTOT0g
 vQWWsRvS9LyQ==
Subject: Re: [PATCH 0/3] add channel constraint for BDW machine drivers
To:     Brent Lu <brent.lu@intel.com>, alsa-devel@alsa-project.org
Cc:     Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
        Liam Girdwood <liam.r.girdwood@linux.intel.com>,
        Jie Yang <yang.jie@linux.intel.com>,
        Mark Brown <broonie@kernel.org>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>, Ben Zhang <benzh@chromium.org>,
        Mac Chiang <mac.chiang@intel.com>,
        Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>,
        Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
        linux-kernel@vger.kernel.org
References: <1587976638-29806-1-git-send-email-brent.lu@intel.com>
From:   Cezary Rojewski <cezary.rojewski@intel.com>
Message-ID: <1375d0b1-fafa-95b5-9a06-eefb1897ca42@intel.com>
Date:   Mon, 27 Apr 2020 13:01:14 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.6.0
MIME-Version: 1.0
In-Reply-To: <1587976638-29806-1-git-send-email-brent.lu@intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 2020-04-27 10:37, Brent Lu wrote:
> The machine driver bdw-rt5650 (for Google buddy) supports 2 or 4-channel
> recording while other two drivers support only 2-channel recording. HW
> constraints are implemented to reflect the hardware limitation on BDW
> platform.
> 

Message body relates to bdw-rt5650 while the series touches every of BDW 
boards.

Apart from review given for each and every patch (although most issues 
are shared so there is not as much to address) my question is:
- are these hw limitations or software (machine board) limitations?

Czarek

> Brent Lu (3):
>    ASoC: bdw-rt5677: channel constraint support
>    ASoC: bdw-rt5650: channel constraint support
>    ASoC: broadwell: channel constraint support
> 
>   sound/soc/intel/boards/bdw-rt5650.c | 34 ++++++++++++++++++++++++++++++++++
>   sound/soc/intel/boards/bdw-rt5677.c | 33 +++++++++++++++++++++++++++++++++
>   sound/soc/intel/boards/broadwell.c  | 33 +++++++++++++++++++++++++++++++++
>   3 files changed, 100 insertions(+)
>