Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Gareth Williams <gareth.williams.jx@renesas.com>
To:     Sam Ravnborg <sam@ravnborg.org>
CC:     Thierry Reding <thierry.reding@gmail.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        Phil Edworthy <phil.edworthy@renesas.com>,
        "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 3/3] drm/panel: simple: Add Newhaven ATXL#-CTP panel
Thread-Topic: [PATCH 3/3] drm/panel: simple: Add Newhaven ATXL#-CTP panel
Thread-Index: AQHWHG0QohXUe8Vg/0OYS6a4UMIWGaiMplYAgAAKxkA=
Date:   Mon, 27 Apr 2020 11:03:58 +0000
Message-ID: <TY2PR01MB29248DC3123F2AFAE80005F2DFAF0@TY2PR01MB2924.jpnprd01.prod.outlook.com>
References: <1587975709-2092-1-git-send-email-gareth.williams.jx@renesas.com>
 <1587975709-2092-4-git-send-email-gareth.williams.jx@renesas.com>
 <20200427084108.GA21216@ravnborg.org>
In-Reply-To: <20200427084108.GA21216@ravnborg.org>
Accept-Language: en-GB, en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: renesas.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: f6b195e1-0b1a-45f0-c201-08d7ea9aaf80
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Apr 2020 11:03:58.4729
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 53d82571-da19-47e4-9cb4-625a166a4a2a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: UcG++FN05950SV8hA2IbwyjBKHO0pSEDTOzj/dQmT2txCG9QydLPoR2VDbSIXRRzYGUuAZh/YX0oQ+AJ+HVy/WpRqGIfLosLOTFtWwZJiTY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY2PR01MB4585
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Sam,

Thanks for giving feedback. When I send out v2 I'll CC you on the rest of t=
he series
to be sure you have visibility. My responses are below.

> On Mon, Apr 27, 2020 at 09:41:49AM +0100, Sam Ravnborg wrote:
> Hi Gareth.
>=20
> Looking forward to see the other patches - they seem to be stuck awaiting
> approval.
>=20
> A few comments in the following.
>=20
> 	Sam
>=20
> On Mon, Apr 27, 2020 at 09:21:49AM +0100, Gareth Williams wrote:
> > This commit adds support for the Newhaven ATXL#-CTP panel used by the
> > Renesas RZ/N1 Demo Board.
> >
> > Signed-off-by: Gareth Williams <gareth.williams.jx@renesas.com>
> > ---
> >  drivers/gpu/drm/panel/panel-simple.c | 27
> +++++++++++++++++++++++++++
> >  1 file changed, 27 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/panel/panel-simple.c
> > b/drivers/gpu/drm/panel/panel-simple.c
> > index 5a93c4e..0b57b0e 100644
> > --- a/drivers/gpu/drm/panel/panel-simple.c
> > +++ b/drivers/gpu/drm/panel/panel-simple.c
> > @@ -2021,6 +2021,30 @@ static const struct panel_desc
> newhaven_nhd_43_480272ef_atxl =3D {
> >  		     DRM_BUS_FLAG_SYNC_DRIVE_POSEDGE,  };
> >
> > +static const struct display_timing
> newhaven_nhd_50_800480tf_atxl_timing =3D {
> > +	.pixelclock =3D { 33300000, 33400000, 33500000 },
> > +	.hactive =3D { 800, 800, 800 },
> > +	.hfront_porch =3D { 40, 40, 40 },
> > +	.hback_porch =3D { 88, 88, 88 },
> > +	.hsync_len =3D { 1, 1, 1 },
> > +	.vactive =3D { 480, 480, 480 },
> > +	.vfront_porch =3D { 13, 13, 13 },
> > +	.vback_porch =3D { 32, 32, 32 },
> > +	.vsync_len =3D { 3, 3, 3 },
> > +	.flags =3D DISPLAY_FLAGS_HSYNC_HIGH |
> DISPLAY_FLAGS_VSYNC_HIGH, };
> > +
> > +static const struct panel_desc newhaven_nhd_50_800480tf_atxl =3D {
> > +		.timings =3D &newhaven_nhd_50_800480tf_atxl_timing,
> > +		.num_timings =3D 1,
> > +		.bpc =3D 8,
> > +		.size =3D {
> > +			.width =3D 400,
> > +			.height =3D 300,
> > +		},
> > +		.bus_flags =3D DRM_BUS_FLAG_DE_HIGH,
> Please add DRM_BUS_FLAG_PIXDATA too - as I assume this is an LVDS panel.

This is an RGB interface, however the manual lists that the rising edge is
being used so I will include the DRM_BUS_FLAG_PIXDATA_SAMPLE_POSEDGE
flag.

>=20
> > +};
> For new panels .connector_type is mandatory.
Okay, I will include this in v2 of the series.

>=20
>=20
> > +
> >  static const struct display_timing nlt_nl192108ac18_02d_timing =3D {
> >  	.pixelclock =3D { 130000000, 148350000, 163000000 },
> >  	.hactive =3D { 1920, 1920, 1920 },
> > @@ -2964,6 +2988,9 @@ static const struct of_device_id
> platform_of_match[] =3D {
> >  		.compatible =3D "newhaven,nhd-4.3-480272ef-atxl",
> >  		.data =3D &newhaven_nhd_43_480272ef_atxl,
> >  	}, {
> > +		.compatible =3D "newhaven,nhd-5.0-800480tf-atxl",
> > +		.data =3D &newhaven_nhd_50_800480tf_atxl,
> > +	}, {
>=20
> I did not see the other patches - so this is maybe covered.
> But newhaven,nhd-5.0-800480tf-atxl must be documented in panel-
> simple.yaml before we can apply this.

I will include a separate documentation patch in v2 with you
on CC for this.


>=20
> 	Sam
>=20
> >  		.compatible =3D "nlt,nl192108ac18-02d",
> >  		.data =3D &nlt_nl192108ac18_02d,
> >  	}, {
> > --
> > 2.7.4

	Gareth