Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp2761640ybz; Mon, 27 Apr 2020 04:08:52 -0700 (PDT) X-Google-Smtp-Source: APiQypLg5zjMrPLSS8BIHCBC/180J4QdlEP2j/jZhhDpfWPrZmI221hHzJGJ3b54GGtJqn+S7nWE X-Received: by 2002:aa7:cdd9:: with SMTP id h25mr18674374edw.17.1587985731972; Mon, 27 Apr 2020 04:08:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587985731; cv=none; d=google.com; s=arc-20160816; b=vmruaFqppRzCwexNcLT9dQJMV65nTJ/1PbUKchN87gOdeAEh7syLFgmfuSMrVLUI7p 4GO68oR7lS57GljYGwBXEyROeERZqczZfSHP/0rKqXfcuQX9uQvwyUdHfBMP8ohanXd4 db//AQRs58mnv8xKuf4jM0p9ErTvu4SSJtYlnJkCkJqZ2wv6Tql47REEwu0a/N+i4zxK fJM99bSLcNXGx0ScKILCQssYKFJkEo9InngQga0Hfbm5h7e+FcFG97EVnw4VAZ2lW44Y aIajsa8oIs9QJBIWCsxMhdvcF9qVHCmf7UlAdkwaFYGh1wsZ3uRS3GxAHDU2Cj5ewDSc eigw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=gUgMPVmIxYJ1cW7CDdu0J0aOLa2IteSKMo0RYY5en+I=; b=mL0wcuNToBdnbFI3DOeMk4jPIQ2/HTEAPuyPF48KnsLajzeFWOKIGLX4Tsuou1xeS/ yra4IkC+Wc181It9cMQaFuagB0KbRCQbIf6n6db2KGxA/WRUI2OfpcAwKGsUICJJ1lEm Tsin3O8/mSENNXD8wSrG+p9plfgDvOZ9Zl3HlbR3FOxM71S3YnAW3AwQlIr2hOF4e8dQ rT6J0osJ4I+IxUnTvgAf9JZs3Y2gBtGTDk4UlkmF02wo3cpNrRqc+dmqnQmeC0gZQ9N7 VfKxBHXB4wZzKlmY2TvEOb+WoPjrAHPFngYO2HqoeksXhCeEIJ1NIy4aCw+7xeMO/41e lvdw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y21si8037285ejq.259.2020.04.27.04.08.26; Mon, 27 Apr 2020 04:08:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726938AbgD0LG5 (ORCPT + 99 others); Mon, 27 Apr 2020 07:06:57 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:53212 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726485AbgD0LG5 (ORCPT ); Mon, 27 Apr 2020 07:06:57 -0400 Received: from DGGEMS411-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 7C8E7C60C90427A39914; Mon, 27 Apr 2020 19:06:54 +0800 (CST) Received: from localhost.localdomain.localdomain (10.175.113.25) by DGGEMS411-HUB.china.huawei.com (10.3.19.211) with Microsoft SMTP Server id 14.3.487.0; Mon, 27 Apr 2020 19:06:45 +0800 From: Wei Yongjun To: Lee Jones CC: Wei Yongjun , , Subject: [PATCH] mfd: wcd934x: Drop kfree for memory allocated with devm_kzalloc Date: Mon, 27 Apr 2020 11:08:05 +0000 Message-ID: <20200427110805.154447-1-weiyongjun1@huawei.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT X-Originating-IP: [10.175.113.25] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org It's not necessary to free memory allocated with devm_kzalloc and using kfree leads to a double free. Signed-off-by: Wei Yongjun --- drivers/mfd/wcd934x.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/mfd/wcd934x.c b/drivers/mfd/wcd934x.c index 90341f3c6810..da910302d51a 100644 --- a/drivers/mfd/wcd934x.c +++ b/drivers/mfd/wcd934x.c @@ -280,7 +280,6 @@ static void wcd934x_slim_remove(struct slim_device *sdev) regulator_bulk_disable(WCD934X_MAX_SUPPLY, ddata->supplies); mfd_remove_devices(&sdev->dev); - kfree(ddata); } static const struct slim_device_id wcd934x_slim_id[] = {