Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp2766049ybz; Mon, 27 Apr 2020 04:13:19 -0700 (PDT) X-Google-Smtp-Source: APiQypIfDC7UpfSHS3OJVVu/+ikdJ50EWEO597XgQqvQ6lLsM+xDdHpXjxiL1nFscKwZgcl9D3i3 X-Received: by 2002:a17:906:e210:: with SMTP id gf16mr19445979ejb.214.1587985999524; Mon, 27 Apr 2020 04:13:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587985999; cv=none; d=google.com; s=arc-20160816; b=MidNYD5AODMavPSRyqXOasMGPT1Uyej8Fu+SfsfyBLaJmMHbTueaTlJjC39Fu5CaZS OCqV5mc/SYNZnyc1tOYRwiHWEjDL2nHuVe4DhAo3Vb3jsLNtmv+jd0kPxoLo7Ch5LcEp 0vnNLIK8b+uKcSSiTG5Mp0RDQrDdHnq2degehi6wyBAUc1OuQBSzrBxxzfMFbDRo7bMK aIA/aWEMAlKg4NjuXjsTppiDQIePmErl+MSW2BmmR63GflYvlmOxNobpY4ipHuaUD1lX b2b2Q5p972xCK7ZgfDJi1iesJBD/Z4HBO2HZ8cnBdB3x/SERjUJeoS8sS08gNv3IJnv+ iCMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=U8E0hfaeNREDyQzBugoTdqXTWs5VAgl6KpzhJdoUSng=; b=I8gawDmOpv0/hXf5TAUoJbVdiOQNmx03HS4ImmhS/2cJ0fsv+BHyE9kau7CPJefkes /MUUvN5s6vgol7iSc8UmjgTjSHiyn5DXRlSW0/rRgxJANsnUix4OIV9AC6y2P+ZQy+4T I+Kz7h7xCjk/XG+SYEAsrPJNbe8mR82m3jhUlFtGzRWWKV1mdInPMEksGLD8K01ru7IS VqB6imwEyIlBkgQOgbCSsoAORkAKrqqYhO9ROkqYR/fJE0mOpwyHbcLePiGHS+hdWZO4 OjEdCi+CK4wwKMTbmjYMKHNQiVvVVu2LoUVIKiHVQ4yUZPeBPuD17eJQUixaaMvE7YPO /pcw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id op2si8221054ejb.395.2020.04.27.04.12.55; Mon, 27 Apr 2020 04:13:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727015AbgD0LKx (ORCPT + 99 others); Mon, 27 Apr 2020 07:10:53 -0400 Received: from smtp07.smtpout.orange.fr ([80.12.242.129]:56741 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726987AbgD0LKw (ORCPT ); Mon, 27 Apr 2020 07:10:52 -0400 Received: from localhost.localdomain ([92.148.159.11]) by mwinf5d13 with ME id XnAl2200P0F2omL03nAman; Mon, 27 Apr 2020 13:10:51 +0200 X-ME-Helo: localhost.localdomain X-ME-Auth: Y2hyaXN0b3BoZS5qYWlsbGV0QHdhbmFkb28uZnI= X-ME-Date: Mon, 27 Apr 2020 13:10:51 +0200 X-ME-IP: 92.148.159.11 From: Christophe JAILLET To: okaya@kernel.org, agross@kernel.org, bjorn.andersson@linaro.org, vkoul@kernel.org, dan.j.williams@intel.com Cc: linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Christophe JAILLET Subject: [PATCH] dmaengine: qcom_hidma: Simplify error handling path in hidma_probe Date: Mon, 27 Apr 2020 13:10:43 +0200 Message-Id: <20200427111043.70218-1-christophe.jaillet@wanadoo.fr> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org There is no need to call 'hidma_debug_uninit()' in the error handling path. 'hidma_debug_init()' has not been called yet. Signed-off-by: Christophe JAILLET --- drivers/dma/qcom/hidma.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/dma/qcom/hidma.c b/drivers/dma/qcom/hidma.c index 411f91fde734..87490e125bc3 100644 --- a/drivers/dma/qcom/hidma.c +++ b/drivers/dma/qcom/hidma.c @@ -897,7 +897,6 @@ static int hidma_probe(struct platform_device *pdev) if (msi) hidma_free_msis(dmadev); - hidma_debug_uninit(dmadev); hidma_ll_uninit(dmadev->lldev); dmafree: if (dmadev) -- 2.25.1