Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp2776288ybz; Mon, 27 Apr 2020 04:24:39 -0700 (PDT) X-Google-Smtp-Source: APiQypK0wJObxHe/OJ5BZga7/s71L+kpdhhHHPRTdno+MU3wcQpYicA/OnHBuuEOsh2HXJK8jWxv X-Received: by 2002:aa7:cf16:: with SMTP id a22mr17801689edy.77.1587986679537; Mon, 27 Apr 2020 04:24:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587986679; cv=none; d=google.com; s=arc-20160816; b=KhqQro2rm5vzdkM3AJ7tD0Qr8rDjoR9zz0x2/uCmEWgURQ5m8SC7EixtAr2huiJFH6 iARHGTON5AfCX/+Wa/ZQd7ZSLASLRAor8ysGghfzK8GP4BqWduvTn96ENHQ8Xojv7/LQ d3p6BKaVGFOHhxfb+G7IgmjiIkh3dVJ7m/MDw4XE9jtdbiDSqITDnNnrhbngE2/lac7U 0fB210uTBrmQfSGGqsx8Sgq5enRPrdchH3eyff2VFb0DY7j90Oj5Zt57sxq0kWBxlVyJ j0o0ZipyfzrOdHRqBU5mXi/zFg457gOSGHqRV9Agcn9lxWIpmT4xB+nWQo87k0cz17u6 oRbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=B+5kQncfoqQzR7ReveKue47rNw5alchWu6khlESHi4w=; b=IaN/LD6/soVBAreQNXS/CbM52qlCD+ZArVh3tURQkY3gBZ97G0CrHRfRBx9RRUcIdF oje4J9yIRE/f0JM0fZP4PrBKKQ9WGllSSm3e3MhLLDUUZcYaevV6tzvl4rr0ITPJvq8q xUOz8q7nKg7V+fcaF0gdkPkzB5hjXfGUU436/K5LMhnzizdhR3FrD2DLSwjOzeB6gu/U bh6N/2LTd/0TFnYEvR8vW8x2XSDHu6J2uy6zxLU//k6V370vfvUDmnT8Bja0E+KnqQiX LSv8ABNq7exwSu7nEfn0x4jhp5Y++GvXpeQDdXrC7sCx7qMvHeLivojkXqx+KY/F3DZu X1Ww== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=oMCK4UYl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p25si8080085eji.408.2020.04.27.04.24.16; Mon, 27 Apr 2020 04:24:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=oMCK4UYl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726604AbgD0LWG (ORCPT + 99 others); Mon, 27 Apr 2020 07:22:06 -0400 Received: from mail.kernel.org ([198.145.29.99]:36222 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726260AbgD0LWF (ORCPT ); Mon, 27 Apr 2020 07:22:05 -0400 Received: from localhost (fw-tnat.cambridge.arm.com [217.140.96.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A319B205C9; Mon, 27 Apr 2020 11:22:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587986525; bh=0jmC6ymb22IxBunv3XGNmRuVyT/qlxFM1kkb/eWadrs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=oMCK4UYlbGod1a1y5XvygMeHe8P1YvmunwSWbIIZ552DSBYHSFnaTtzvitje4yc5D UzTJgJwuPOO6O26FCKCXDrZ5nLtvogMTIbATLS/45lkyOxvE8oz98oRZNmjLdx9+Y8 prTJZl+Z5mrHc6TlOUvyi31ZKDG5NOWMKWlkKNSY= Date: Mon, 27 Apr 2020 12:22:02 +0100 From: Mark Brown To: Marek Szyprowski Cc: patches@opensource.cirrus.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Sylwester Nawrocki , Lee Jones , Charles Keepax , Liam Girdwood Subject: Re: [PATCH 4/4] ASoC: wm8994: Silence warnings during deferred probe Message-ID: <20200427112202.GB4272@sirena.org.uk> References: <20200427074832.22134-1-m.szyprowski@samsung.com> <20200427074832.22134-5-m.szyprowski@samsung.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="98e8jtXdkpgskNou" Content-Disposition: inline In-Reply-To: <20200427074832.22134-5-m.szyprowski@samsung.com> X-Cookie: Secrecy is the beginning of tyranny. User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --98e8jtXdkpgskNou Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Apr 27, 2020 at 09:48:32AM +0200, Marek Szyprowski wrote: > Don't confuse user with meaningless warning about the failure in getting > clocks in case of deferred probe. > if (ret < 0) { > - dev_err(&pdev->dev, "Failed to get clocks: %d\n", ret); > + if (ret != -EPROBE_DEFER) > + dev_err(&pdev->dev, "Failed to get clocks: %d\n", ret); This completely eliminates the diagnostics which means that if the clock isn't there the user is a bit stuck trying to work out what's missing. There should still be a diagnostic. --98e8jtXdkpgskNou Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl6mwFkACgkQJNaLcl1U h9CnKgf+L0DHzyP9uJrX9mcCSOEFMqGDbUbVooabgQKACLN2NqFor9WHedKckCIh fDOp+RpDynCvnBX7erSNkPM8Hkpo8VemUi+ULRs+Bj2qP1h6t+069tYs+AZ8f9VJ dAWfnctdgI8rYKrfwFa7zPToZbEYNX+3tZHwBMwnpW12+maRF788h2uas/h6Ae2s 9o0nObKwrSLLvvnqvFXGPeX6UZ4kXayfQ8RojLR+y+QtkcLZTZeB2WGuowRS62wD yccW4mzrZojzcC3aSuuCosv3h9wEMbMb+g1PIF4cCUGz14oywcWiVBDiEi7uMSWp oyQQZ6ObUxSdmIvqgirYU5GA67W+wA== =MSap -----END PGP SIGNATURE----- --98e8jtXdkpgskNou--