Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200408143040.57458-1-max.krummenacher@toradex.com>
In-Reply-To: <20200408143040.57458-1-max.krummenacher@toradex.com>
From:   Arnd Bergmann <arnd@arndb.de>
Date:   Mon, 27 Apr 2020 13:25:38 +0200
Message-ID: <CAK8P3a104Njrxb7vh+YJGpSBxW2ODMJ6M+PvN=WAuM_VRBM9bQ@mail.gmail.com>
Subject: Re: [PATCH v2 0/5] defconfig: fix changed configs and refresh
To:     Max Krummenacher <max.oss.09@gmail.com>
Cc:     Max Krummenacher <max.krummenacher@toradex.com>,
        Anson Huang <Anson.Huang@nxp.com>,
        Geert Uytterhoeven <geert+renesas@glider.be>,
        Li Yang <leoyang.li@nxp.com>,
        Catalin Marinas <catalin.marinas@arm.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Vidya Sagar <vidyas@nvidia.com>,
        Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>,
        Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
        Olof Johansson <olof@lixom.net>,
        Shawn Guo <shawnguo@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Will Deacon <will@kernel.org>,
        Linux ARM <linux-arm-kernel@lists.infradead.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Apr 8, 2020 at 4:31 PM Max Krummenacher <max.oss.09@gmail.com> wrote:
>
> Three configs have been renamed and/or changed behaviour.
> Clean that by using the new config name.
> With the name change to DRM_SIMPLE_BRIDGE the related
> DRM_DISPLAY_CONNECTOR got introduced, enable that additionally.
>
> Then refresh the defconfig with make defconfig savedefconfig.
>
> The refreshed defconfig does result in a not changed .config.
>
> Applies on linux-next/master tag: next-20200407
>
>
> Changes in v2:
> - additional patch adding DRM_DISPLAY_CONNECTOR as recommended by Geert and Laurent
> - add reviewed-by tags

Thank you for the series!

When you are reasonably confident that you have done these patches correctly,
feel free to send them to soc@kernel.org so they make it into the
lore.kernel.org
patchwork instance and we pick them up from there.

From the description, I guess the first four are supposed to be
applied as bugfixes
for v5.7, and the last one is meant as a cleanup and queued for v5.8? Please
indicated in the cover letter what you think should happen with them, then we
can either follow that suggestion or see if anyone disagrees.

For the last patch, I want a better description, as you do not say how you made
sure that nothing else changed that needs to be addressed with a separate
patch. From the diffstat "1 file changed, 7 insertions(+), 10 deletions(-)", it
sounds like seven options got moved around but did not change behavior,
but three others have either disappeared or also got renamed. I could look
more closely to see what happened exactly, but I'd prefer this to be obvious
from the changelog.

        Arnd