Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp2822697ybz; Mon, 27 Apr 2020 05:17:25 -0700 (PDT) X-Google-Smtp-Source: APiQypJeTrnmuS7iNw1VUX1X5e8g/N+dKPl8LGUCb+AZE9VxpNswFSUJNK1GOE/EkOD22C7agIwh X-Received: by 2002:a17:906:d291:: with SMTP id ay17mr19582394ejb.183.1587989845429; Mon, 27 Apr 2020 05:17:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587989845; cv=none; d=google.com; s=arc-20160816; b=BtxBhXl9Oxemx9WP4jLw8RYw75Mq0AOQ0GtDft0jai49fr1c+VAIrisIe4L+JtGCn5 Qcg4ComDPs6HkixP2qfG8uy6AXAMigkRQSewDLTJTJFPHvcHb5SCBwGoVaw7Uogqc2GM OPnFr76qy7T206b+o0IXnkQiCYZ8t5tcPHIVZbQq2dgy2ePxnwuNSUo2k8ule26KAge4 ky7126DFB+DPQJGB7vdjagQicnX8rGX45eC7dvEbx2BTBFSp9FN5n8bOr4M5UP8zZ3Fc kmfNv6tIvDTRxt1JmHWje75SLzsbNEGYhp8EB4X2wMAh9OU/dnfpA4JiNnY5dwXf1gna 3xfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=9lVfEVc5L8znQ+c7F3WTTTw7wU9+m3a1YYMINWxHStM=; b=e5mGy9RahIkliyvu56VAJVdDZAcESynHyILn8kRM1dM3EbtkVe9FsLIsd+gZCEdNmQ awKOxrhNp0JAE2AQiZSoyYQZS16KbWQ/F53RnKGxMm77sAIXfv7KWhhHO3PRGvdrP7An e99Yoszw+WqDd9MHvwXa4+Z0GD2OM8ybQPQs7pmx9HG0gWRZUdfEHeiOSy5Sf5lZpErA PwZbJImIHXFOWj0cHxmC6bteGkMcrm6KgKbavi9hopTILBOqcBWCCMRjzbhkHIOsiktn AbJlEQTbycIB90kDP+quDNvc0umUEOJwj2xxLAU+EPgAXMMCUgw6q8tyszPrIGQU3pBn ArBA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o15si8129325eje.13.2020.04.27.05.16.53; Mon, 27 Apr 2020 05:17:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727055AbgD0MNi (ORCPT + 99 others); Mon, 27 Apr 2020 08:13:38 -0400 Received: from jabberwock.ucw.cz ([46.255.230.98]:47350 "EHLO jabberwock.ucw.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726260AbgD0MNi (ORCPT ); Mon, 27 Apr 2020 08:13:38 -0400 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id E1B151C0244; Mon, 27 Apr 2020 14:13:36 +0200 (CEST) Date: Mon, 27 Apr 2020 14:13:36 +0200 From: Pavel Machek To: Colin King Cc: Jacek Anaszewski , Dan Murphy , linux-leds@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] leds: trigger: remove redundant assignment to variable ret Message-ID: <20200427121336.GB544@duo.ucw.cz> References: <20200420221229.99150-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="l76fUT7nc3MelDdI" Content-Disposition: inline In-Reply-To: <20200420221229.99150-1-colin.king@canonical.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --l76fUT7nc3MelDdI Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon 2020-04-20 23:12:29, Colin King wrote: > From: Colin Ian King >=20 > The variable ret is being assigned with a value that is never read > and it is being updated later with a new value. The initialization is > redundant and can be removed. >=20 > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King Thanks, applied. Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --l76fUT7nc3MelDdI Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABECAB0WIQRPfPO7r0eAhk010v0w5/Bqldv68gUCXqbMcAAKCRAw5/Bqldv6 8o7rAKCm8ntQEIFtZ61dXMpp4NXClLfyAQCfZtfwQz4pO6W+FS3+iyVfQR//BYc= =omzN -----END PGP SIGNATURE----- --l76fUT7nc3MelDdI--