Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp2833592ybz; Mon, 27 Apr 2020 05:30:10 -0700 (PDT) X-Google-Smtp-Source: APiQypKfPscqYMsfWUAVa+4kT3H7Sn/PnAs2R1Fi0azEscCrWX5bkZGdXg3geqbI/5CIPNnLjpGS X-Received: by 2002:a17:906:361a:: with SMTP id q26mr20083605ejb.292.1587990610031; Mon, 27 Apr 2020 05:30:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587990610; cv=none; d=google.com; s=arc-20160816; b=kpquCkej9xXncxRlfDpvBFLLIacV9ZkhfbKp5odP1SKEr9+N4k50vuM96kxeuWaLRW 6wJTP+wyLPUJuUVi8zm1s1vKbPk56zJNWvwxsyynjK6ywnNNFqFPCRsJeNZdFtUb1Qcm wn4hcISI1WYE1BoUa9KZ/g9xwuNK1/OiPLNMlATYLCvCwmvmy3LfgFJVOWM6qgc57DjA KjBq0hcSISCHXitHA7M2+snSX03L+CpEDFpjxzAdfBEY9zZaB2O8mws3pOlsAskgmD7I 8xGunPd6wlQDPuO7xSNFcbp1m6kMTSwBR1afBm8JE/tC96EQwUNcWsqArxqb1tMXS55a N2tQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=UMqJjW1ZYxYVEiGfapdTOMQe1y0DxEv7GoL3YQaAW2c=; b=KziGYE2bws9MGXT5XYh7T3yGaUHVgUY4do0XJUt3uofqpPN+FEYLuCpI7e2MaZ0eYG KLMZAHSv11GuRA0avmOHZlKs+/r1keqHp+iY5kQH2iDLQ4dCAE0Zp0svbsFBILpZG0ax smreLu/+5qy+J03noQ5Gotj3zBE9IDuGzBhNT+7GrZ4gVc4kVPed3xJxBhGuZPY9+bwJ 46Isuju37v8AJQi4FxOms4YNWGDZ7ccM0/K8oyIFNk/wSGyAd1qtoMRTxtmwbM+O+cpC Z/pM0nJM3pKF/JJEQWsB7FFCU0iXPddmod1wkFZLzR01nIvMuHtv5TovBz6mZISn+uAF M4nQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e8si8050678ejt.23.2020.04.27.05.29.45; Mon, 27 Apr 2020 05:30:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727042AbgD0M2O (ORCPT + 99 others); Mon, 27 Apr 2020 08:28:14 -0400 Received: from szxga07-in.huawei.com ([45.249.212.35]:32966 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726589AbgD0M2O (ORCPT ); Mon, 27 Apr 2020 08:28:14 -0400 Received: from DGGEMS411-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id AE24871CBB5878793B39; Mon, 27 Apr 2020 20:28:12 +0800 (CST) Received: from localhost.localdomain.localdomain (10.175.113.25) by DGGEMS411-HUB.china.huawei.com (10.3.19.211) with Microsoft SMTP Server id 14.3.487.0; Mon, 27 Apr 2020 20:28:04 +0800 From: Wei Yongjun To: Lee Jones , Srinivas Kandagatla CC: Wei Yongjun , , Subject: [PATCH] mfd: wcd934x: Drop kfree for memory allocated with devm_kzalloc Date: Mon, 27 Apr 2020 12:29:22 +0000 Message-ID: <20200427122922.56643-1-weiyongjun1@huawei.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200427110805.154447-1-weiyongjun1@huawei.com> References: <20200427110805.154447-1-weiyongjun1@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT X-Originating-IP: [10.175.113.25] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org It's not necessary to free memory allocated with devm_kzalloc and using kfree leads to a double free. Fixes: 6ac7e4d7ad70 ("mfd: wcd934x: Add support to wcd9340/wcd9341 codec") Signed-off-by: Wei Yongjun --- drivers/mfd/wcd934x.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/mfd/wcd934x.c b/drivers/mfd/wcd934x.c index 90341f3c6810..da910302d51a 100644 --- a/drivers/mfd/wcd934x.c +++ b/drivers/mfd/wcd934x.c @@ -280,7 +280,6 @@ static void wcd934x_slim_remove(struct slim_device *sdev) regulator_bulk_disable(WCD934X_MAX_SUPPLY, ddata->supplies); mfd_remove_devices(&sdev->dev); - kfree(ddata); } static const struct slim_device_id wcd934x_slim_id[] = {