Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 6017BC433D2
Subject: Re: [PATCH V2 2/3] iio: adc: Add PMIC7 ADC bindings
To:     Rob Herring <robh@kernel.org>
Cc:     agross@kernel.org, bjorn.andersson@linaro.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        mka@chromium.org, linus.walleij@linaro.org,
        Jonathan.Cameron@huawei.com, smohanad@codeaurora.org,
        kgunda@codeaurora.org, aghayal@codeaurora.org,
        Jonathan Cameron <jic23@kernel.org>,
        Hartmut Knaack <knaack.h@gmx.de>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
        Mark Rutland <mark.rutland@arm.com>, linux-iio@vger.kernel.org,
        linux-arm-msm@vger.kernel.org, linux-arm-msm-owner@vger.kernel.org
References: <1586942266-21480-1-git-send-email-jprakash@codeaurora.org>
 <1586942266-21480-3-git-send-email-jprakash@codeaurora.org>
 <20200420220244.GA32739@bogus>
From:   Jishnu Prakash <jprakash@codeaurora.org>
Message-ID: <5de6ad40-1ce6-6f53-15d8-236f0685a2bb@codeaurora.org>
Date:   Mon, 27 Apr 2020 18:24:43 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.7.0
MIME-Version: 1.0
In-Reply-To: <20200420220244.GA32739@bogus>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Rob,

On 4/21/2020 3:32 AM, Rob Herring wrote:
> On Wed, Apr 15, 2020 at 02:47:45PM +0530, Jishnu Prakash wrote:
>>                 of 512 will be used.
>>               - For compatible property "qcom,spmi-adc5", valid values are 250, 420
>>                 and 840. If property is not found, default value of 840 is used.
>> +            - For compatible property "qcom,spmi-adc7", valid values are 85, 340
>> +              and 1360. If property is not found, default value of 1360 is used.
> We express constraints in schema now, don't duplicate with free form
> text.
I'll remove the redundant parts of the descriptions in the next post.
>
>>               - For compatible property "qcom,spmi-adc-rev2", valid values are 256,
>>                 512 and 1024. If property is not present, default value is 1024.
>> +    then:
>> +      patternProperties:
>> +        "^.*@[0-9a-fx]+$":
> 'x' should not be in unit-addresses.
I'll remove it in the next post.
>
>> +          properties:
>> +            qcom,decimation:
>> +              items:
> Not an array, so 'items' doesn't make sense here.
I'll remove it in the next post.
>
>> +                enum: [ 85, 340, 1360 ]
>> +                default: 1360
>> +
>>