Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp2874629ybz; Mon, 27 Apr 2020 06:13:31 -0700 (PDT) X-Google-Smtp-Source: APiQypI0BT0HVt5VJfDvsQOZJRbHrqrx4RoayC8q5GWOW5E02Gjy2TPNIQs1lE6Lf6eDFHRtBp5X X-Received: by 2002:a05:6402:391:: with SMTP id o17mr18525068edv.71.1587993211135; Mon, 27 Apr 2020 06:13:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587993211; cv=none; d=google.com; s=arc-20160816; b=MIlM8PbH1k+8KwEw4eO0i4pOv6NSJPmbRmG1FrYPG3VTw1eVrTLLobgN4jC8VsAYhr yoqqWCUcvIjgP9M13U+4Zsvnyh+awCs0vqFpaYkEIoc6BzvkaBItLJK72fdKoB+j14VJ yfyzSeSL3Nt0XZdcmeYwjBuj58/2aTcNECJTLovPchZuT6N+RHdpvVvuHZ8OxeAauN5N 4JA0Njl6LjFOtabHSey7IqSrOO55eVY0n7B9ejqpJZfa96xD4KhVY5bE742T/a2Yk52d euDKxysyc98s4LJ94LkRHZltsnFcULqted5A2Z/UuEwvt7u6rDYLElUOR7re9OeCSrMD nKxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:subject:references:in-reply-to :cc:to:from:date:dkim-signature; bh=fEsZCmOLN7WJh2cBFl2IFs13P7b6B7VB6fBsoBdP5Xk=; b=YH+/U9nutiR/Ge17bL8F11OKhjgDc9Xpw2mVH60cAZqyGxRl/Z5+XU1Au9CYEWtWo+ zzBXyVf7T0yGtPmdhcKoDbMA1D+Mq8gl36eHKkSGwNKlhfwdLZIWNACIJKQuKVwsfEgN 1TkA5CC7hKdQfZ4MVjJJLR+LFtQ30tSz8Zf9+lqKtaJU3TqTuRSyqKDjudwiIGQP202R zjlINd6LNCgXnh4n6sNr0steyBOPUzs+AdXgZxI1KZyy6squUeq8KjI17A3uAM2uJz38 mFs9dH2fvdvw0I3cZc0SGCACI0AHE9+cMzV1C9kBZfx0wTyz4aU9dqr1kPM5bYmMhSws yhNA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=TGwGFnbh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g3si7412590edp.190.2020.04.27.06.13.03; Mon, 27 Apr 2020 06:13:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=TGwGFnbh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727115AbgD0NJO (ORCPT + 99 others); Mon, 27 Apr 2020 09:09:14 -0400 Received: from mail.kernel.org ([198.145.29.99]:46710 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726651AbgD0NJO (ORCPT ); Mon, 27 Apr 2020 09:09:14 -0400 Received: from localhost (fw-tnat.cambridge.arm.com [217.140.96.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 643F22074F; Mon, 27 Apr 2020 13:09:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587992953; bh=F2J5+tCyCW2blznWC3DoSWefBae/flCTMt9vpZT3jpQ=; h=Date:From:To:Cc:In-Reply-To:References:Subject:From; b=TGwGFnbhgQsP++okUZdhRpPetk91J/pmzJ3IZb7o7KWrWLNaye1tT9g9iFKbb6HOP R5Mz+EMS9WZ7ajlO028s1+ZYpR1BABPxXrJI7jV5I2HqBFQPiUdJXuMna/DYWGF0NI 2/8/qwkasN9awJw28hjtggcP5QFH8Wi/l08yoROs= Date: Mon, 27 Apr 2020 14:09:11 +0100 From: Mark Brown To: perex@perex.cz, timur@kernel.org, alsa-devel@alsa-project.org, tiwai@suse.com, festevam@gmail.com, Shengjiu Wang , Xiubo.Lee@gmail.com, nicoleotsuka@gmail.com, lgirdwood@gmail.com Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org In-Reply-To: References: Subject: Re: [PATCH v2] ASoC: fsl_easrc: Check for null pointer before dereferencing "ctx" in fsl_easrc_hw_free() Message-Id: <158799293953.30174.7045413410563193676.b4-ty@kernel.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 25 Apr 2020 15:19:29 +0800, Shengjiu Wang wrote: > The patch 955ac624058f: "ASoC: fsl_easrc: Add EASRC ASoC CPU DAI > drivers" from Apr 16, 2020, leads to the following Smatch complaint: > > sound/soc/fsl/fsl_easrc.c:1529 fsl_easrc_hw_free() > warn: variable dereferenced before check 'ctx' (see line 1527) > > sound/soc/fsl/fsl_easrc.c > 1526 struct fsl_asrc_pair *ctx = runtime->private_data; > 1527 struct fsl_easrc_ctx_priv *ctx_priv = ctx->private; > ^^^^^ > Dereference > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-5.8 Thanks! [1/1] ASoC: fsl_easrc: Check for null pointer before dereferencing "ctx" in fsl_easrc_hw_free() commit: f3fc1ea011f09156886e8f4beb240ea814f2197a All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark