Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] lib/test_lockup.c: make test_inode static
To:     Jason Yan <yanaijie@huawei.com>, akpm@linux-foundation.org,
        linux-kernel@vger.kernel.org
Cc:     Hulk Robot <hulkci@huawei.com>
References: <20200417074021.46411-1-yanaijie@huawei.com>
From:   Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
Message-ID: <4b210d34-5dae-63c7-4fde-3332b99b0159@yandex-team.ru>
Date:   Mon, 27 Apr 2020 16:29:03 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.7.0
MIME-Version: 1.0
In-Reply-To: <20200417074021.46411-1-yanaijie@huawei.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-CA
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 17/04/2020 10.40, Jason Yan wrote:
> Fix the following sparse warning:
> 
> lib/test_lockup.c:145:14: warning: symbol 'test_inode' was not declared.
> Should it be static?

Yep, but that's not so important.

> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>
> ---
>   lib/test_lockup.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/test_lockup.c b/lib/test_lockup.c
> index ea09ca335b21..419fbaceba73 100644
> --- a/lib/test_lockup.c
> +++ b/lib/test_lockup.c
> @@ -142,7 +142,7 @@ module_param(reallocate_pages, bool, 0400);
>   MODULE_PARM_DESC(reallocate_pages, "free and allocate pages between iterations");
>   
>   struct file *test_file;

Why you're fixing only this warning? =)
test_file above should generate the same.

> -struct inode *test_inode;
> +static struct inode *test_inode;
>   static char test_file_path[256];
>   module_param_string(file_path, test_file_path, sizeof(test_file_path), 0400);
>   MODULE_PARM_DESC(file_path, "file path to test");
>