Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp2908556ybz; Mon, 27 Apr 2020 06:48:05 -0700 (PDT) X-Google-Smtp-Source: APiQypLtr34TtRf0FnsuhaOcwJAz1FEzSDS1OeYGRDewK3qjomzpOWz7QlXNezisnTw+g1k3oslz X-Received: by 2002:a17:906:fcaf:: with SMTP id qw15mr19514646ejb.236.1587995285789; Mon, 27 Apr 2020 06:48:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587995285; cv=none; d=google.com; s=arc-20160816; b=phsalwsM+OWGIcHPJDjcBvlq+wF2oCoXHXMPrXqC3Ofyzf0DXp3PwKSkxRhHGdjYnI bBXyRjhoTyZJo0ZvbmgAYLSQcxMLg3x5DueIdpLMEdq2R3Crp5gFoCFZmjXyzIOo/fDX GXZ1pSY6ciJc8X3u3Sl0X3JEPVy1F7VBxmIF6vJM39Khme5tV5cUbd824SZ9kRJpp5WN XU5nUfVFWN/LyN+uDiU+a89k9iuJOlfkR5v52SJsFk6P87U8N9vDKFQvRmpl2KEAJrBC XjbIO0oLP30HjZ1O4Rk2QdtviNs5oqkjtPJt4vAibUg3FdsCRneJdbTR3Dv9VWEL51nl Zokw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=IPXAcvXcV2/d9kI79OZTRlGrFnnhZBRTqFBK9NFYYNo=; b=DKo29dB9WS1kBRoEJ7KgNqJKTa3KrkYMlyBRvJ8io/JecIqktuAumL27kue62A01cZ d5PeIkCHICXaT7m/+tHS3wtUUeIUKdMSknl7HynCIiFFwyL1NWFJEPESAFgASznP97bR umSBd5wzfX8aFfPtelF1vI9sDg8HB78841pcO0Wtw1chdAAA/LrlkVtiCcEkJCrARsjw qsECwxNC4oPK/hqFsBNM0ZjRB0SCoJEAdvHvztp2fXrNGW3rBroDNZqgzMO3H9T+yJXQ 53Ibt6iQHhM4yDUTahKPcS0XThX9P2t/LHHDnwt/5Vuc3S/LsrRUk6fwwIVao3+kQCAJ 07Rw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=ZQ9vgXpu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id aq26si8467084ejc.26.2020.04.27.06.47.42; Mon, 27 Apr 2020 06:48:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=ZQ9vgXpu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728070AbgD0NqY (ORCPT + 99 others); Mon, 27 Apr 2020 09:46:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55626 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726539AbgD0NqV (ORCPT ); Mon, 27 Apr 2020 09:46:21 -0400 Received: from mail-il1-x143.google.com (mail-il1-x143.google.com [IPv6:2607:f8b0:4864:20::143]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F2E53C0610D5; Mon, 27 Apr 2020 06:46:20 -0700 (PDT) Received: by mail-il1-x143.google.com with SMTP id r2so16691839ilo.6; Mon, 27 Apr 2020 06:46:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=IPXAcvXcV2/d9kI79OZTRlGrFnnhZBRTqFBK9NFYYNo=; b=ZQ9vgXpuNsftTocxa/gp7w7Z0HBor8F0po5cZ172t1RmqMKsnkmMShjqqnG86eH3hw Qn4vCrTz5XhM9B8frrKmP/E17ibTUNT3CFJJmg6/ZVN1TGo02U7TQGjcfhXY7vuu1L7s PuaU1W/28Bg2FTMtQMZaYU/rAn7sSIcjnFSMPeTTMH6yG1zLBx7dC9jgI2JeLKfAii2s vgOF7qxce8q8n1JUDs2n/GfEDRzgMluH58WhzFAUwdlt/B82iw6WDFtdMe57EqdIvRA2 mh3y0fY9pV+3+HsbcwDFGsxZMo1Tx5RJfdoFoRZIDlo3DVc7W/5ExoF+IYS+4SWknnJf EXCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=IPXAcvXcV2/d9kI79OZTRlGrFnnhZBRTqFBK9NFYYNo=; b=iuxxgcm7tz6VF1ZAYTiPatVsbQfrDczsWDcw9cJGpeXCt7hELViT6M5wxmNvBQQaKP t+9+i18UhrLmjZiTq4dvOkCcuuvnPnsZvJe8j1YE4iXd4oyx7moJhfAfWlFPydLcl8at NKB1lVUdO0gK/a3CscAsbmt8VEMdw+PsfAlZdA+zbwLJauYpXqGzWLx41Pa62Hp/eiPu oJ6gIhofJ3KvaoK2xqvcCvR6njAGOzHteM4T4oT3yWQ8BMpfcPfl/H+NZWHc+2xl93l4 f7TpUK+TG0ilAEz3IRvC52LyHFqYqM9gUJd2KA3ReqSRis+08rqsobNZrnMTtqBAavnx /Jmw== X-Gm-Message-State: AGi0Pubqu2/Yb3tTcWDt/8DXTKdiGaKsNJaAKeKXcnO3YjIip+qjN52y DXBwEddSHTggfIWhiC9KNRQ2B6l3OzWYnlT3kQkmnA== X-Received: by 2002:a92:d2c1:: with SMTP id w1mr18902521ilg.96.1587995180392; Mon, 27 Apr 2020 06:46:20 -0700 (PDT) MIME-Version: 1.0 References: <1585733475-5222-1-git-send-email-chakragithub@gmail.com> In-Reply-To: From: Chakra Divi Date: Mon, 27 Apr 2020 19:16:08 +0530 Message-ID: Subject: Re: [PATCH] fuse:rely on fuse_perm for exec when no mode bits set To: Miklos Szeredi Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 21, 2020 at 4:21 PM Chakra Divi wrote: > > On Mon, Apr 20, 2020 at 4:55 PM Miklos Szeredi wrote: > > > > On Wed, Apr 1, 2020 at 11:31 AM Chakra Divi wrote: > > > > > > In current code, for exec we are checking mode bits > > > for x bit set even though the fuse_perm_getattr returns > > > success. Changes in this patch avoids mode bit explicit > > > check, leaves the exec checking to fuse file system > > > in uspace. > > > > Why is this needed? > > Thanks for responding Miklos. We have an use case with our remote file > system mounted on fuse , where permissions checks will happen remotely > without the need of mode bits. In case of read, write it worked > without issues. But for executable files, we found that fuse kernel is > explicitly checking 'x' mode bit set on the file. We want this > checking also to be pushed to remote instead of kernel doing it - so > modified the kernel code to send getattr op to usespace in exec case > too. Any help on this Miklos.... Thanks, Chakra > > Thanks, > > Miklos