Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp2978024ybz; Mon, 27 Apr 2020 07:55:50 -0700 (PDT) X-Google-Smtp-Source: APiQypLBLpDZ+x6uam+//VkA9Xnz6EPVjdKu/+kgTBgDl9PM89CNr//7wD7rtiXJNnqTT/Ygp+58 X-Received: by 2002:a17:906:82d2:: with SMTP id a18mr19647053ejy.373.1587999350320; Mon, 27 Apr 2020 07:55:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587999350; cv=none; d=google.com; s=arc-20160816; b=Ql2oNGh4vYDFAlbjA5x5B9EhTGRVmfYE8MCgjJFwhVPUeTAD4ILEsN0voC3OcQ45va y62L8QWa9y0u2tqlecooK5DJbR1fg9m/+1AaT0YHq+Ma8ua1YUyqe1Zkexdn61ftavne TGPXpeW0RtwZs2DEN4LHlAJcDHsauGNdkspAE9oqHI3CPJ85oIGLbneOHs+t0vB+FcWk cODT46EwLaB3SN1zw0Toxcorl0/c++WgmWP05JrnHhVOFiBkaSDJZorPOabe7QgqwPgV MAbwdyREe/GvW/Ovj+dF+kb7qM5PKJmO86gn9DtfYl9DgDJAOJKLB4wYkYHukQWvKT6p x06Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=76L+05pXG0YYo+XtN//BndNqA6/3be9LNPRgH9iB/sY=; b=VFf33j9yQ2YOR0110KzmVQAUHgqIXgNNKRehVG+dMZbyrhHHxuWvYqmktt2f2B0K3R rX9rbE4rsPiv2oKqDi1mi8YEjM0d4jZoS+cYjPxOF1aiKPtpQeHPccGoxmYFLxWFqol6 AFsRVJuwXJAD9eTzjdZyqTVJa1fNI4TI69+Qhd5mPT8bfpjcmPflhebFmko+NI5TIKbQ +Bp5aLHChb5VEWo4h8Im6qaplQmJe0GguKtFcmBKBo533OLHDOP0J8ZkwWaL9SVyAYf9 N23G9GqVpyP2okpv9QXF09AR7d102fGng4CDQZbw70E7Yh6SRKn8QCxUmrBk5R6IPTP6 +2hw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l19si7657104edr.184.2020.04.27.07.55.26; Mon, 27 Apr 2020 07:55:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727949AbgD0Oxk (ORCPT + 99 others); Mon, 27 Apr 2020 10:53:40 -0400 Received: from verein.lst.de ([213.95.11.211]:48733 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727010AbgD0Oxk (ORCPT ); Mon, 27 Apr 2020 10:53:40 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 593EA68C7B; Mon, 27 Apr 2020 16:53:38 +0200 (CEST) Date: Mon, 27 Apr 2020 16:53:38 +0200 From: Christoph Hellwig To: Martijn Coenen Cc: axboe@kernel.dk, hch@lst.de, ming.lei@redhat.com, narayan@google.com, zezeozue@google.com, kernel-team@android.com, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, maco@google.com, bvanassche@acm.org, Chaitanya.Kulkarni@wdc.com, jaegeuk@kernel.org Subject: Re: [PATCH v3 2/9] loop: Factor out setting loop device size Message-ID: <20200427145338.GB5490@lst.de> References: <20200427074222.65369-1-maco@android.com> <20200427074222.65369-3-maco@android.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200427074222.65369-3-maco@android.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 27, 2020 at 09:42:15AM +0200, Martijn Coenen wrote: > This code is used repeatedly. > > Signed-off-by: Martijn Coenen Looks good, Reviewed-by: Christoph Hellwig