Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp2981759ybz; Mon, 27 Apr 2020 07:59:48 -0700 (PDT) X-Google-Smtp-Source: APiQypIyHhBPsuwTmFLs9HhkEiTDfQU6+wEOqN4lzsXXq4AcYOmwSa2FeIVOTNw9yAfqhtyK2/pp X-Received: by 2002:aa7:d1d6:: with SMTP id g22mr19244957edp.36.1587999588655; Mon, 27 Apr 2020 07:59:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587999588; cv=none; d=google.com; s=arc-20160816; b=NdOm1ScljDdCnRmZzrUTiLfkbD4/4Hj6n/Li1HkweXwcl584CGxRIN0gI2ZCNDgtLG PhfkahDVOKqAL4SkSseM6NzP5jgpnVOhH5Xz986yM+qHYJh+nAxq0BnVD/D3JEBOO52a ux/EsEF0ZlXAp4gHiyNGaUQAJoIr45L0a6wIb5rdNt7eZznq2d9dz7vitlLqbSstuwAi 0LTG0Lm+rbzEVPeRlOlUHfezJbNClXvk94O3ivQvJe3a85czjCrEniAPzDvWo+aqL0HA wZxb8B62JYP9berLMzTYY4JDjjz2Af1IL1bAS1cfK9ywEvoeRZ8UTGm0QaVvla3KRnD+ UGFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=AiBDwHkZrnQduJzAfUVHPDIOK8zKyCsQmaxsvyE6tDs=; b=CEh5GmcnhFMg5gFEs5rofbP14toEC3t5Q96j43sQG73hG1V9us5FR+aMqgUBUV5WQ9 W9kpsEg0TUfhtpTWvo9bwu5NZRJbK9n+9dkUy8ltSPHtoTb41XkDIGArQegjBphATkq6 AthcDLKG2mbV1gP+wS92wWk+YiLfkclbsoEABuSf1qpTy0KO8AiFOXDuP8q5qCJg/qjU YdoCIhN/EjujpAIY5QiPmPVJpR8ze1v/cpIpD8HrnD8i7I8F6ElezeAhlHRNkjy60WJE O90ooiG6T3Ve4JHa49ppydpZvrsqeDQ4GtXCX9NlN78RM6EfZxw1YgIPmNthHAoGzKKC g5gw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id cm18si7780661edb.130.2020.04.27.07.59.25; Mon, 27 Apr 2020 07:59:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728161AbgD0O5V (ORCPT + 99 others); Mon, 27 Apr 2020 10:57:21 -0400 Received: from verein.lst.de ([213.95.11.211]:48786 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727077AbgD0O5U (ORCPT ); Mon, 27 Apr 2020 10:57:20 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 0DD5068C7B; Mon, 27 Apr 2020 16:57:19 +0200 (CEST) Date: Mon, 27 Apr 2020 16:57:18 +0200 From: Christoph Hellwig To: Martijn Coenen Cc: axboe@kernel.dk, hch@lst.de, ming.lei@redhat.com, narayan@google.com, zezeozue@google.com, kernel-team@android.com, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, maco@google.com, bvanassche@acm.org, Chaitanya.Kulkarni@wdc.com, jaegeuk@kernel.org Subject: Re: [PATCH v3 6/9] loop: Factor out configuring loop from status Message-ID: <20200427145718.GF5490@lst.de> References: <20200427074222.65369-1-maco@android.com> <20200427074222.65369-7-maco@android.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200427074222.65369-7-maco@android.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 27, 2020 at 09:42:19AM +0200, Martijn Coenen wrote: > Factor out this code into a separate function, so it can be reused by > other code more easily. > > Signed-off-by: Martijn Coenen Looks good, Reviewed-by: Christoph Hellwig