Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp2982575ybz; Mon, 27 Apr 2020 08:00:32 -0700 (PDT) X-Google-Smtp-Source: APiQypLowXY+sJ5gv9xfYIYgv9BmKX3VERCH+XOTIUpdb9qd+8zG5CgroIhYNuYQhi/dI7hQroqC X-Received: by 2002:a17:906:1c8a:: with SMTP id g10mr20912375ejh.342.1587999631862; Mon, 27 Apr 2020 08:00:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587999631; cv=none; d=google.com; s=arc-20160816; b=hUJjgm6fPmx0UmwpECV0BGGvVSKgwyx56vjRn+ARoqkCgM25kuDUrKfUBefH2LqELD Zwbo6jouXSMy8233kYwvPWR2WQjHGsNQxpdqD0M+fbv746iScWfSw+Gr3SI87Bc5ZKa0 m0U815G0rkoErer2qiCjEmoQkv3uPPEwnz9GSj3vQOa8cgasSZt6tWljVx5VTIgvolRP scYQ+Hv+Z4eTsOrfXIHQrnuiSsCwdKezuwLaXlr1cRvVq3+L4S4HDqR6PwqN6tBs83cE IjU7MwWw2yfq4EH+wtqSO7/fEqhHNAw93QnmlmqZUFvz2z/cOfWwKy7kujpGD+5FB3BC rdTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=cfdW4XP81s2yeS5IuCSJ4eu5DcoVkV6H5iudzBDA9DE=; b=v/GsghmGOidgnD3DHiwdvHFJTVHsl218V8JxmycJuRurZtDA3Q4vNQjlGz66KZ5sa7 gNpf6KcyIvIFpm7wHjZrIX+A3PQZNsbhDq7Hy4Fwe0WkvzaGoDVI6tBeOxmb/h1gkSUu IqP46toQe4WQYLH0P90XN1nCzQvRNm0+RZa4YnfqQjP6ToAASatyIdSp8w9Zj74GDUM0 AuBDkZUDwHgV7eM1zth3TiSl4qVz34dIS7nSuyVcaWM9fB01la2zqAZrTx95bnim7rSH BWPUneeMQLYi+v7ws0xJ38hIdxE3a46t/MycmKzgyMYxSkndkvyA4K6Uhz40WX8K4FOh d/Ng== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w16si8802765ejb.521.2020.04.27.08.00.06; Mon, 27 Apr 2020 08:00:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728182AbgD0O5r (ORCPT + 99 others); Mon, 27 Apr 2020 10:57:47 -0400 Received: from verein.lst.de ([213.95.11.211]:48803 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727073AbgD0O5r (ORCPT ); Mon, 27 Apr 2020 10:57:47 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 8510B68CF0; Mon, 27 Apr 2020 16:57:45 +0200 (CEST) Date: Mon, 27 Apr 2020 16:57:45 +0200 From: Christoph Hellwig To: Martijn Coenen Cc: axboe@kernel.dk, hch@lst.de, ming.lei@redhat.com, narayan@google.com, zezeozue@google.com, kernel-team@android.com, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, maco@google.com, bvanassche@acm.org, Chaitanya.Kulkarni@wdc.com, jaegeuk@kernel.org Subject: Re: [PATCH v3 8/9] loop: Rework lo_ioctl() __user argument casting Message-ID: <20200427145745.GH5490@lst.de> References: <20200427074222.65369-1-maco@android.com> <20200427074222.65369-9-maco@android.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200427074222.65369-9-maco@android.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 27, 2020 at 09:42:21AM +0200, Martijn Coenen wrote: > In preparation for a new ioctl that needs to copy_from_user(); makes the > code easier to read as well. > > Signed-off-by: Martijn Coenen Looks good, Reviewed-by: Christoph Hellwig