Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp2992672ybz; Mon, 27 Apr 2020 08:08:59 -0700 (PDT) X-Google-Smtp-Source: APiQypJLhQB5ZMI7rykGx3kwaOW0nmk9c9W/A8E2vOOrunXoJ5xlLNQZtLnsqwEcIZ8FKec4MZYB X-Received: by 2002:aa7:d78a:: with SMTP id s10mr5695436edq.319.1588000139448; Mon, 27 Apr 2020 08:08:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588000139; cv=none; d=google.com; s=arc-20160816; b=fq7L1YWnxiZrUZSRrGfemMR2czZ/CjH9OxAl+cSf0GY0FZ2wr2T61xy2dTg8xDkk7s +ihWUEe8Csy9CEU2bSu/m84efhhgdyFz8+GqVJ4N96VMb1Y607Bl8DWpLr8GqXyixWx0 K1qxdtUktIFGf0Bu6ficfOkcHsPI7ah8OGjN0Oz0yEJdSDevLODuPsvNagPiZsrtEWd+ YbjlEAnL6jKgLbNOOvLArMhWkZnG0Wzb6XjM1VrWZLaZ+pX5AV0FM/nT9CKn6mkp0oIG tIKKtqy2DQRtn1eq7Tz2oScV9EMUiRiL1VF+Y5zJ2rLdAcYEtBNY6yQKAO3dzAlbApIB l2WQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=VYoG7ckIrqrBjvQNubpK3jDwKfKGSOsi4DshguryQug=; b=C6hAkCGUxp3AHB/QdYUvL18lqYFaZrQLGrH8MBviZLL67S31f7BsJ0w69d2LWLEDX8 IKpaHCI4uEr/IBjdgC0Qu91SwDBqJu+2JxKcc4bF8NUHNVIyw3NFQ7+vQBhsTyxqKKFJ op5xcqaqKlW/XYjCXYj9ayDNdCDd+UaWy3IZHKED5AXYHhvDCj5kCyVzY3ad/KFOAiME 1jxhAIQeFYQ9KQXXumwR8WZAf8CztYm64rYIkToqU6FI94Kk9nx8AbGHO2Zy/xHXSzlt blGE67iz8GeZIbw4BZJBl2bHBPiGGtgY5ym9gOznJzgjX7eo16J/qSAZz9unfsh8XHYo /oOg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a22si8239849edx.81.2020.04.27.08.08.09; Mon, 27 Apr 2020 08:08:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728108AbgD0PGT (ORCPT + 99 others); Mon, 27 Apr 2020 11:06:19 -0400 Received: from verein.lst.de ([213.95.11.211]:48868 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727966AbgD0PGQ (ORCPT ); Mon, 27 Apr 2020 11:06:16 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 3CC5D68C7B; Mon, 27 Apr 2020 17:06:13 +0200 (CEST) Date: Mon, 27 Apr 2020 17:06:12 +0200 From: Christoph Hellwig To: Niklas Cassel Cc: Keith Busch , Jens Axboe , Christoph Hellwig , Sagi Grimberg , Igor Konopko , Matias =?iso-8859-1?Q?Bj=F8rling?= , Javier =?iso-8859-1?Q?Gonz=E1lez?= , Jens Axboe , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] nvme: prevent double free in nvme_alloc_ns() error handling Message-ID: <20200427150612.GA5910@lst.de> References: <20200427123443.520469-1-niklas.cassel@wdc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200427123443.520469-1-niklas.cassel@wdc.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Applied to nvme-5.7. Not a huge fan of it, though - but I think I have an idea how to sort some of this mess out with better block layer APIs.