Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 27 Apr 2020 21:31:03 +0530
From:   Vinod Koul <vkoul@kernel.org>
To:     Alan Mikhak <alan.mikhak@sifive.com>
Cc:     dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-pci@vger.kernel.org, gustavo.pimentel@synopsys.com,
        dan.j.williams@intel.com, kishon@ti.com, maz@kernel.org,
        paul.walmsley@sifive.com
Subject: Re: [PATCH v2][next] dmaengine: dw-edma: Check MSI descriptor before
 copying
Message-ID: <20200427160103.GF56386@vkoul-mobl.Dlink>
References: <1587607101-31914-1-git-send-email-alan.mikhak@sifive.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1587607101-31914-1-git-send-email-alan.mikhak@sifive.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 22-04-20, 18:58, Alan Mikhak wrote:
> From: Alan Mikhak <alan.mikhak@sifive.com>
> 
> Modify dw_edma_irq_request() to check if a struct msi_desc entry exists
> before copying the contents of its struct msi_msg pointer.
> 
> Without this sanity check, __get_cached_msi_msg() crashes when invoked by
> dw_edma_irq_request() running on a Linux-based PCIe endpoint device. MSI
> interrupt are not received by PCIe endpoint devices. If irq_get_msi_desc()
> returns null, then there is no cached struct msi_msg to be copied.
> 
> This patch depends on the following patch:
> [PATCH v2] dmaengine: dw-edma: Decouple dw-edma-core.c from struct pci_dev
> https://patchwork.kernel.org/patch/11491757/
> 
> Rebased on linux-next which has above patch applied.

These two para above should be added after s-o-b line as git-am skips
the lines after the marker. The above line are useful for applying but not
when applied. I have stripped these and applied the patch, thanks

-- 
~Vinod