Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp3111329ybz; Mon, 27 Apr 2020 10:09:02 -0700 (PDT) X-Google-Smtp-Source: APiQypIJfyKbnPSX6UjQCCt5E+hGr1oJ1RLFUVY0ySGUBKzjA8GH90HxiPowmbY5SfdVHKJX0Qfa X-Received: by 2002:aa7:d2cd:: with SMTP id k13mr3171241edr.116.1588007342500; Mon, 27 Apr 2020 10:09:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588007342; cv=none; d=google.com; s=arc-20160816; b=BbQ0xLj19Vmsm6JpvzCFJTCiOaf8GhKiK84oHOgBQWfAJ/SAS/GSn4ZvSCMlo7LqVZ xp+cMhKnQfhFOK1dYT9HUN8585O9ooitDMxy8Zy3g//KvgSHulcAoXokyrMy9Kp+NGhX maql5NAtMmc5u1c4izMXJwOgOaFrGayQ8WnkKIkSfInRRLVQ7Kou6mYzBq0GbQ8zCwF7 SQ0RWq1p2XIMcnKeskAzEIEgACh+CMbGf6KwNS5EQMTuWGAfFfkRBsUUnLytb6dy6Taw EM8e0OeSNCsOq0TDgdfOO3vTs+al771ZHi7zIVCrwrRaBBjcEs8KCngzhm2JNL9SmXuT A4eg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=JVpE8UugzL5XnsGqczaypVEYKu3XzAXglxH7U1HQslM=; b=AX4IvKBdlUAciN0zt6Z+oQOL7D3FpYpQ8YeA3omo31aGGkSu0ScNKnLUSEfWUOQrAg QB3mOZ68tF9IOaR7cVz9DjH2T/gBrf39U5cZOkoiHU1db/6xUcCYFBtdj2N2axMyhBqv k+RgKbkUqiW7cNCuoEk41uakfP058GTFxgL0tP1FHjeJJO+hXYK5RIJ/1ozPwMivp+Aq oVQtdPAvdHVh+ZNjPcztdjddPh4IHTH8jpxxr5QJ4TyxQEq7bhKfuHTChGNNAPJwQAYB BD8E6iccbvwqMav8v147M4tKeFx+EUGLeuN/rlKBuBol6U4bREIkISHMj30abQTKhkPI GIPQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ha13si113300ejb.390.2020.04.27.10.08.27; Mon, 27 Apr 2020 10:09:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726369AbgD0RGR (ORCPT + 99 others); Mon, 27 Apr 2020 13:06:17 -0400 Received: from verein.lst.de ([213.95.11.211]:50039 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725963AbgD0RGR (ORCPT ); Mon, 27 Apr 2020 13:06:17 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id C935B68C7B; Mon, 27 Apr 2020 19:06:13 +0200 (CEST) Date: Mon, 27 Apr 2020 19:06:13 +0200 From: Christoph Hellwig To: Martijn Coenen Cc: axboe@kernel.dk, hch@lst.de, ming.lei@redhat.com, narayan@google.com, zezeozue@google.com, kernel-team@android.com, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, maco@google.com, bvanassche@acm.org, Chaitanya.Kulkarni@wdc.com, jaegeuk@kernel.org Subject: Re: [PATCH v3 0/9] Add a new LOOP_SET_FD_AND_STATUS ioctl Message-ID: <20200427170613.GA13686@lst.de> References: <20200427074222.65369-1-maco@android.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200427074222.65369-1-maco@android.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I've just been looking over the loop driver for other reasons, and noticed that setting the block size still isn't possible with LOOP_SET_FD_AND_STATUS as far as I can tell. Might that be worth it? Also maybe an explicit direct I/O flag, and maybe enough padding with a future proof flags bitmap that we can easily extend it for new features if they pop up?