Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v20 02/17] leds: Add multicolor ID to the color ID list
To:     Pavel Machek <pavel@ucw.cz>
CC:     <jacek.anaszewski@gmail.com>, <linux-leds@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
References: <20200423155524.13971-1-dmurphy@ti.com>
 <20200423155524.13971-3-dmurphy@ti.com> <20200425195242.GA1143@bug>
From:   Dan Murphy <dmurphy@ti.com>
Message-ID: <003891b8-a697-6d55-3862-5773e23a466a@ti.com>
Date:   Mon, 27 Apr 2020 12:12:18 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.7.0
MIME-Version: 1.0
In-Reply-To: <20200425195242.GA1143@bug>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Pavel

On 4/25/20 2:52 PM, Pavel Machek wrote:
> On Thu 2020-04-23 10:55:09, Dan Murphy wrote:
>> Add a new color ID that is declared as MULTICOLOR as with the
>> multicolor framework declaring a definitive color is not accurate
>> as the node can contain multiple colors.
>>
>> Signed-off-by: Dan Murphy <dmurphy@ti.com>
> Please merge with previous patch, and you can keep reviews.

Not sure we should do that.  The previous patches deals directly with 
the bindings and this is code.

I thought the rule was to keep bindings and code separated.

It made sense to squash the bindings header patch to the bindings 
document patch but it does not make sense to squash this patch to the 
bindings.

Please let me know if you want me to proceed with the squash.

Dan