Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp3134784ybz; Mon, 27 Apr 2020 10:34:05 -0700 (PDT) X-Google-Smtp-Source: APiQypK6HRFmj9a8ZvgNVcZdCEJTy82qfKhCvc7TiH52n5pjS0T/sgRN9GyXFpJJ0KU5+wjicr0D X-Received: by 2002:a50:e68e:: with SMTP id z14mr20156582edm.307.1588008845045; Mon, 27 Apr 2020 10:34:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588008845; cv=none; d=google.com; s=arc-20160816; b=eYmmYoJQ9XppDO5AtQcmDOoatcZ47F9cUG/nZyj+abTlChayfq3zc7wkz7kv2m2mRR JUrLwpZxtrEVsYHszXPlJT8tJXY19uTYme5evyXf3y1LPqju+hwwt5JiqOxq0epWLUi0 F26quu+7TwQ84OkkMZXDbqfA41RiUpj3aB2h/mpW946DbzfXI3JtjoF9WDW7tEKwAVnx BGNz/7aKLek+4qwI4V92521ccrGZq1gPmyYLtJufMJN/PMgwgYHihgJsq95HtjFPgolf qDkZArHuTTjhOO0PPuomu7eLtyCJmY0VlDJ3d04bW6YlrZ1DdpAF1lYwaYNSbVQpS1nE 9xzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=q6VuuME2OrFIxo2x0fnYm6sVmXaTMajdyfwwv3J5FeA=; b=O23StbwGaxC0w9qxLpNKMLkbEYen3zP39E9TJJiT0ExZH6tubWTEF8Bqa0qPIfb4D7 bo2vWOC30H50zRP1gXkSGAr+bxef28RHbnpFT/EjSK5nFmL+dVNtHTwi+iNJIBNugFV4 kmcY/J9xT+v/jJqMPDBaT/F3wcMbyGS6LxSOrR0TAPzYsLhjPmuzfLDh2bMumDMMZDY1 hMhAiyyGJzqjoT6ZX9BStNswe1q/N/e1vlD3rB8vR2jzyHjtRtnu6f/+BDHsr78xjB+K /mXHK3uO+79cK448QqwzmrkPjfnjbGR0BTJ3aFICc5WJJWNQer4e5ld3TytW5ps2ibVl NCCw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=MSUAHvji; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k2si139424edh.267.2020.04.27.10.33.42; Mon, 27 Apr 2020 10:34:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=MSUAHvji; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726385AbgD0Rbh (ORCPT + 99 others); Mon, 27 Apr 2020 13:31:37 -0400 Received: from mail.kernel.org ([198.145.29.99]:45672 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726244AbgD0Rbh (ORCPT ); Mon, 27 Apr 2020 13:31:37 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4464E20775; Mon, 27 Apr 2020 17:31:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588008696; bh=sQuHvJ8hED/DxfS8jREtJCqTkhgs+wdBCB4nmSyo64Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=MSUAHvjim2B5zkwUH81DpVvb9f5Af9nvOVGON+fWy6Pl3f4f9JKnPNWBguiH6soWT M51gp+VtCd++fOceKouXW6MDiUTJpEqgW/2ghM+k06Rh0qcXC8NOwbnXDuHv/+HKb0 FbXnluTxO5RPPGoGWxT4wjGOADtC/NiVSgAJxzMI= Date: Mon, 27 Apr 2020 19:31:34 +0200 From: Greg Kroah-Hartman To: youngjun Cc: Tejun Heo , linux-kernel@vger.kernel.org Subject: Re: [PATCH] kernfs: fix possibility of NULL pointer dereference. Message-ID: <20200427173134.GC3936841@kroah.com> References: <20200427164836.48765-1-her0gyugyu@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200427164836.48765-1-her0gyugyu@gmail.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 27, 2020 at 09:48:36AM -0700, youngjun wrote: > When dentry is negative, "kernfs_dentry_node" returns NULL. > In this case, "kernfs_root" dereferences NULL pointer. > > Signed-off-by: youngjun > --- > fs/kernfs/dir.c | 18 ++++++++++-------- > 1 file changed, 10 insertions(+), 8 deletions(-) And how can this be triggered on a kernfs filesystem? thanks, greg k-h