Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp3164430ybz; Mon, 27 Apr 2020 11:06:49 -0700 (PDT) X-Google-Smtp-Source: APiQypKGBQr9nMDjrUgtN1bVpyuqJKMKZ0idhre6CIkbesKb1NIcohx6EbNkxBZGZJeNBflPe8Jh X-Received: by 2002:a17:906:7c0c:: with SMTP id t12mr8073335ejo.2.1588010809292; Mon, 27 Apr 2020 11:06:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588010809; cv=none; d=google.com; s=arc-20160816; b=B69EMlFgHC3qA/xaOE505SNyp5Lc3xRhFnQby262Vuu6zR0/P1C3skf/1YAvx8yezi hnIP8vurV7Lob5WYnsTRHoEVZ78ltMCTBNBaikuva34DqzVDVP6kQODpV4Rvu459XEGc Lrsn/kV1nQu1csfuDAucF5pisWoQ7c/b6cYpCvOTB/zDbBKO0es5M3Frg2lvYuJaie0D 97hxxTL6pqRZZO/QUvF4fZ9IHdvc6lw6n5/ws+BoyzUydaNgsN0VcPnJhLUVu72OYgKA zO92JtDuXZZpMUbUMQX0LoYet8HzJS6cHu0euAQwl6/N/0zumi6JVgQNNj64XmpV22JB FyAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=/O8XjVq3Se81PztNsnUfnGC5+N+FRIy1vxzKGmvuyUE=; b=v6uMOJMwRb93sM93IbCrCClv0ZtbpHqtb+ILcmM9Pb+AZQDwhs7xK1lbryZgdfLS+2 p7s7qSTI+sFHDfkfNP7DJreZeB89l8sQRLEnDx3eOH1OVJO/KAoK0pGYVCd2xyzxmJjn kTKqrD2W3xGbwk72KIXgnuzfZi9R8TTcGAuDyP4ycfOYEWi0BJCNH+kkasZVXb/6eMpB 9rRy6/XcNBF7POwE3RLJBrGtv+seHvK4IAYDfGc6A1Z4NFka5Nvil4h92EmirOHP4x/m vfaefNiNo6h2i3UpsLzBLSFYXLcuwN4RbaHKqadCsTglhETmKPSl5sjL8hfYi9jHEBtx FH0A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z6si185750edm.108.2020.04.27.11.06.16; Mon, 27 Apr 2020 11:06:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726295AbgD0SEb (ORCPT + 99 others); Mon, 27 Apr 2020 14:04:31 -0400 Received: from smtp10.smtpout.orange.fr ([80.12.242.132]:17580 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726230AbgD0SEb (ORCPT ); Mon, 27 Apr 2020 14:04:31 -0400 Received: from localhost.localdomain ([93.22.148.32]) by mwinf5d88 with ME id Xu4R2200P0iASfR03u4S9E; Mon, 27 Apr 2020 20:04:29 +0200 X-ME-Helo: localhost.localdomain X-ME-Auth: Y2hyaXN0b3BoZS5qYWlsbGV0QHdhbmFkb28uZnI= X-ME-Date: Mon, 27 Apr 2020 20:04:29 +0200 X-ME-IP: 93.22.148.32 From: Christophe JAILLET To: balbi@kernel.org, gregkh@linuxfoundation.org, colin.king@canonical.com, stern@rowland.harvard.edu, arnd@arndb.de, andrzej.p@samsung.com Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Christophe JAILLET Subject: [PATCH] usb: gadget: net2272: Fix a memory leak in an error handling path in 'net2272_plat_probe()' Date: Mon, 27 Apr 2020 20:04:23 +0200 Message-Id: <20200427180423.88514-1-christophe.jaillet@wanadoo.fr> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 'dev' is allocated in 'net2272_probe_init()'. It must be freed in the error handling path, as already done in the remove function (i.e. 'net2272_plat_remove()') Fixes: 90fccb529d24 ("usb: gadget: Gadget directory cleanup - group UDC drivers") Signed-off-by: Christophe JAILLET --- drivers/usb/gadget/udc/net2272.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/usb/gadget/udc/net2272.c b/drivers/usb/gadget/udc/net2272.c index a8273b589456..5af0fe9c61d7 100644 --- a/drivers/usb/gadget/udc/net2272.c +++ b/drivers/usb/gadget/udc/net2272.c @@ -2647,6 +2647,8 @@ net2272_plat_probe(struct platform_device *pdev) err_req: release_mem_region(base, len); err: + kfree(dev); + return ret; } -- 2.25.1