Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp3175687ybz; Mon, 27 Apr 2020 11:18:42 -0700 (PDT) X-Google-Smtp-Source: APiQypL3qrewIQDEWJkmGJoEVU1fVEiK4VSgvbYxZYAj/sj9oQ+M9yLjoA7Wpe83dbCSO8rsaqY0 X-Received: by 2002:a17:907:11de:: with SMTP id va30mr21295592ejb.121.1588011522466; Mon, 27 Apr 2020 11:18:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588011522; cv=none; d=google.com; s=arc-20160816; b=m9Gf7xeOlcoH8nr6e8UcX3M6Tp04evokHHLXiioO8xlDvK1kARHQQlRYQh3i6QAHwW H3scTFrxmmqj0ee0b+BUf7lFAxVv38gntJNelcWRMZbKhfbiHDc3iSwro1GEK2TcIVB5 5uhNSybWT98+XnkVWIIrM7WjtqQk8pI73FGE9cb7epoThV3kuvtxcrX5ZTdxz+Z4ds8B W3q0qbYulDY/hww7DsMFSLDu9+DCGFvUis4c66EHk5uQ8l3CbyaIypb3i3j1bKvHMU60 LV5FwQ2fX5RH7spGpTLSWY9axF3XLl865LFQQGgRTNTLnRJgEeyxPhMDF/EheK7aWS4t Yp7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=mHZFghItfezap+b6c2YGuEGJjQIrgil3o0ihyPQjOo8=; b=pX7PuTzjCGM/1OZz2ELM1fW6SxsTxN0LNG3WCAeJjP9JKCtswF0IzE8K3Le8Ur3ygg VW5nmsANzW7CpimdW6R9Khc6vPeDv2whNiRi5udJdzqcQTkLaBdwNhJWOTZZW6CECECl 36039Edhzvs1iaoHOOl0t3FaUreL73Zs/GFYySqVCo95nMqAeXoetzbV1qESnsN/xk0H e9ZMTzSuFYeyZbci2uZwCg2cw1Ks3Cq0fYaWjKtkuZP0ohAR908wBwCnJ0gPXAdn7lCQ 4FeUOZ8yOGL+hvoupLNvNZNz/z/RG0BJU36kvKYdnojhWrYyH9ivikkR4M45ngyHtghV Twpg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f23si225078ejf.414.2020.04.27.11.18.13; Mon, 27 Apr 2020 11:18:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726315AbgD0SOa (ORCPT + 99 others); Mon, 27 Apr 2020 14:14:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41228 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1725963AbgD0SOa (ORCPT ); Mon, 27 Apr 2020 14:14:30 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2DB15C0610D5; Mon, 27 Apr 2020 11:14:30 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id E598915D53D4C; Mon, 27 Apr 2020 11:14:28 -0700 (PDT) Date: Mon, 27 Apr 2020 11:14:28 -0700 (PDT) Message-Id: <20200427.111428.371576843109032987.davem@davemloft.net> To: colin.king@canonical.com Cc: netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: rtnetlink: remove redundant assignment to variable err From: David Miller In-Reply-To: <20200425112814.137857-1-colin.king@canonical.com> References: <20200425112814.137857-1-colin.king@canonical.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 27 Apr 2020 11:14:29 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Colin King Date: Sat, 25 Apr 2020 12:28:14 +0100 > From: Colin Ian King > > The variable err is being initializeed with a value that is never read > and it is being updated later with a new value. The initialization > is redundant and can be removed. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King Applied, thanks.