Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp3177101ybz; Mon, 27 Apr 2020 11:20:13 -0700 (PDT) X-Google-Smtp-Source: APiQypLbY7DgEY8MUCrupQUi4rMV2EYYIvBkC5OkZl/m18fBai7J1mgwK2wlDTA2oZQYDZKSVudf X-Received: by 2002:a05:6402:286:: with SMTP id l6mr19801639edv.134.1588011613797; Mon, 27 Apr 2020 11:20:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588011613; cv=none; d=google.com; s=arc-20160816; b=gYuVpYoMeruFbVAbQErq5Y9+Kb7ak9zVjtV7SLmUqJAwGsjG6aUy2tNCo7u//p3PtD 6gsjcs7IlzxaRO2/THlLE37aCuFZ9XAOH42ZllLVGiuRrPAjprSEXhXbaow2Jre2AlKX 0I19U98GcV+S8vYBYMmLPe+PSstiiFa8ZMehlFzEk4Kmf6u5OTD9tPDFGQT/fgkIgEvR pjzcJqS1h/UNR93HG0cw4lXgtYw18S+VZZp2hKrfTJmevpg1eW81uGD7te+mvL0xzabf Xaind3PJI2TbbzM6xC8XfGOUWBNe+mJn/Bx07X60RfvCEfoDtPdVvQuYYGA3zZ4+K8sD RAQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=tdn4ZRgbSngp2JjSNIlT3JcC/p1icHpam5JvtoltCNs=; b=sF0N/MDlhlVvl1wF6167kk+j/8gk1GUfnjjSQWfBbFdVvogKBhAJoyRMdDETcSQpMw NHaiB2WneR2BI8ZazqsGeS9opBRaS7Gxz3KtdVTKvg3XWWhdj9+Wm/0li2Wv3YNUcidn zYsWoxheTTo2GXiPdHvDMGFQjmyhNCettNseldGxZBJBrpTLnVJp9k1/60TZtv3hGghq nSeNfNFGsxbZ+R2HsCHb3nrHyGLPovN2/mBZj0wHwjIIvW2U0PmA9A4zW8hgLE9VsbCq tV5Pt+TO+2rBsOJZbl40TMYw5GyLYO/Sswvd/pXCBm3je5Pi+LxLI4sDp1Vfmi5OA6be tpOg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k6si210338edq.268.2020.04.27.11.19.50; Mon, 27 Apr 2020 11:20:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726371AbgD0SPs (ORCPT + 99 others); Mon, 27 Apr 2020 14:15:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41452 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1725963AbgD0SPs (ORCPT ); Mon, 27 Apr 2020 14:15:48 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1A049C0610D5; Mon, 27 Apr 2020 11:15:48 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id BCCFC104D0E41; Mon, 27 Apr 2020 11:15:47 -0700 (PDT) Date: Mon, 27 Apr 2020 11:15:47 -0700 (PDT) Message-Id: <20200427.111547.346558310845161759.davem@davemloft.net> To: zhengdejin5@gmail.com Cc: tglx@linutronix.de, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v1] ethernet: ks8842: delete unnecessary goto label From: David Miller In-Reply-To: <20200425115612.17171-1-zhengdejin5@gmail.com> References: <20200425115612.17171-1-zhengdejin5@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 27 Apr 2020 11:15:47 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dejin Zheng Date: Sat, 25 Apr 2020 19:56:12 +0800 > the label of err_register is not necessary, so delete it to > simplify code. > > Signed-off-by: Dejin Zheng It's not unnecessary, it's documenting the state of the probe.