Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: zlf9d9uYAcSATKoHyYLhhnEoQ1N3h4vEXIIY30uEE/4cv/9Gmr/IJWJm/2WqZys4ogIPJHMRGC
 Wc8hdWEylO9w==
IronPort-SDR: xS5JlL4vBwEjAeyxOBw1yzPjRI4rbG6eNCk7vvICju1Ms07GnCA27am4N65H/iXU8l9gxoyGGR
 r7Et6egwICCQ==
Subject: Re: [PATCH] firmware: stratix10-svc: Drop unnecessary checking for
 and populating /firmware/ node
To:     Sudeep Holla <sudeep.holla@arm.com>
Cc:     linux-kernel@vger.kernel.org
References: <20200421173256.34897-1-sudeep.holla@arm.com>
 <8ca3666f-8ff1-3c3c-d40b-81c024b37bdd@linux.intel.com>
 <20200423081149.GB18538@bogus>
From:   Richard Gong <richard.gong@linux.intel.com>
Message-ID: <2b2e29ec-ebbf-3ee6-acc9-3722a2fabbfb@linux.intel.com>
Date:   Mon, 27 Apr 2020 14:12:56 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.9.0
MIME-Version: 1.0
In-Reply-To: <20200423081149.GB18538@bogus>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Sudeep,

In our dts, firmware is not under root node. You can refer to 
arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi for details.

This is why we need check and populate firmware node.

Regards,
Richard

On 4/23/20 3:11 AM, Sudeep Holla wrote:
> On Wed, Apr 22, 2020 at 04:50:00PM -0500, Richard Gong wrote:
>> Hi Sudeep,
>>
>> I tried and couldn't load stratix10-svc driver with your patch on kernel
>> 5.6.
>>
> 
> What exactly do you mean by not loading stratix10-svc driver ?
> This patch doesn't change that part, the driver should still get loaded.
> The change may affect probing part if for some reason the devices for
> nodes under firmware are not populated which I still can't understand.
> 
> Do you see any change under i/sys/devices/platform/firmware\:* with
> and without this change ?
> 
> Lots of drivers removed the code similar to this patch after the Commit
> 3aa0582fdb82 ("of: platform: populate /firmware/ node from
> of_platform_default_populate_init()") and continue to work fine. I am
> interested to see what is different in stratix10-svc.
> 
> --
> Regards,
> Sudeep
>