Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200424181642.32084-1-pop.adrian61@gmail.com> <20200427064910.GC3559@dell>
In-Reply-To: <20200427064910.GC3559@dell>
From:   Adrian Pop <pop.adrian61@gmail.com>
Date:   Mon, 27 Apr 2020 21:59:59 +0300
Message-ID: <CAP-HsdQOyWrz+Y7gR9jrNjX09NCYB1EWK7swMQDZ-v-VJLGRMw@mail.gmail.com>
Subject: Re: [PATCH 1/2] arm: dt-bindings: mfd: stm32f-rcc: Add missing DSI clock
To:     Lee Jones <lee.jones@linaro.org>
Cc:     Alexandre Torgue <alexandre.torgue@st.com>,
        Maxime Coquelin <mcoquelin.stm32@gmail.com>,
        Rob Herring <robh+dt@kernel.org>, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        linux-stm32@st-md-mailman.stormreply.com,
        devicetree@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Apr 27, 2020 at 9:49 AM Lee Jones <lee.jones@linaro.org> wrote:
>
> On Fri, 24 Apr 2020, Adrian Pop wrote:
>
> > Add missing clock.
> >
> > Signed-off-by: Adrian Pop <pop.adrian61@gmail.com>
> > ---
> >  include/dt-bindings/mfd/stm32f7-rcc.h | 1 +
> >  1 file changed, 1 insertion(+)
>
> I assume patch 2 depends on this?

Yes, second patch depends on this.

>
> If so, where is it?  Why isn't it in my inbox?
>

Here it is:

STM32f769-disco features a 4" MIPI DSI display: add support for it.

Signed-off-by: Adrian Pop <pop.adrian61@gmail.com>
---
 arch/arm/boot/dts/stm32f746.dtsi      | 34 ++++++++++++++++++
 arch/arm/boot/dts/stm32f769-disco.dts | 50 +++++++++++++++++++++++++++
 2 files changed, 84 insertions(+)

diff --git a/arch/arm/boot/dts/stm32f746.dtsi b/arch/arm/boot/dts/stm32f746=
.dtsi
index 93c063796780..202bb6edc9f1 100644
--- a/arch/arm/boot/dts/stm32f746.dtsi
+++ b/arch/arm/boot/dts/stm32f746.dtsi
@@ -48,6 +48,19 @@ / {
        #address-cells =3D <1>;
        #size-cells =3D <1>;

+       reserved-memory {
+               #address-cells =3D <1>;
+               #size-cells =3D <1>;
+               ranges;
+
+               linux,dma {
+                       compatible =3D "shared-dma-pool";
+                       linux,dma-default;
+                       no-map;
+                       size =3D <0x10F000>;
+               };
+       };
+
        clocks {
                clk_hse: clk-hse {
                        #clock-cells =3D <0>;
@@ -75,6 +88,27 @@ clk_i2s_ckin: clk-i2s-ckin {
        };

        soc {
+               ltdc: display-controller@40016800 {
+                       compatible =3D "st,stm32-ltdc";
+                       reg =3D <0x40016800 0x200>;
+                       interrupts =3D <88>, <89>;
+                       resets =3D <&rcc STM32F7_APB2_RESET(LTDC)>;
+                       clocks =3D <&rcc 1 CLK_LCD>;
+                       clock-names =3D "lcd";
+                       status =3D "disabled";
+               };
+
+               dsi: dsi@40016c00 {
+                       compatible =3D "st,stm32-dsi";
+                       reg =3D <0x40016c00 0x800>;
+                       interrupts =3D <98>;
+                       clocks =3D <&rcc 1 CLK_F769_DSI>, <&clk_hse>;
+                       clock-names =3D "pclk", "ref";
+                       resets =3D <&rcc STM32F7_APB2_RESET(DSI)>;
+                       reset-names =3D "apb";
+                       status =3D "disabled";
+               };
+
                timer2: timer@40000000 {
                        compatible =3D "st,stm32-timer";
                        reg =3D <0x40000000 0x400>;
diff --git a/arch/arm/boot/dts/stm32f769-disco.dts
b/arch/arm/boot/dts/stm32f769-disco.dts
index 1626e00bb2cb..30ebbc193e82 100644
--- a/arch/arm/boot/dts/stm32f769-disco.dts
+++ b/arch/arm/boot/dts/stm32f769-disco.dts
@@ -153,3 +153,53 @@ &usbotg_hs {
        pinctrl-names =3D "default";
        status =3D "okay";
 };
+
+&dsi {
+       #address-cells =3D <1>;
+       #size-cells =3D <0>;
+       status =3D "okay";
+
+       ports {
+               #address-cells =3D <1>;
+               #size-cells =3D <0>;
+
+               port@0 {
+                       reg =3D <0>;
+                       dsi_in: endpoint {
+                               remote-endpoint =3D <&ltdc_out_dsi>;
+                       };
+               };
+
+               port@1 {
+                       reg =3D <1>;
+                       dsi_out: endpoint {
+                               remote-endpoint =3D <&dsi_in_panel>;
+                       };
+               };
+
+       };
+
+       panel: panel {
+               compatible =3D "orisetech,otm8009a";
+               reg =3D <0>; /* dsi virtual channel (0..3) */
+               reset-gpios =3D <&gpioj 15 GPIO_ACTIVE_LOW>;
+               status =3D "okay";
+
+               port {
+                       dsi_in_panel: endpoint {
+                               remote-endpoint =3D <&dsi_out>;
+                       };
+               };
+       };
+};
+
+&ltdc {
+       dma-ranges;
+       status =3D "okay";
+
+       port {
+               ltdc_out_dsi: endpoint {
+                       remote-endpoint =3D <&dsi_in>;
+               };
+       };
+};
--

> > diff --git a/include/dt-bindings/mfd/stm32f7-rcc.h b/include/dt-binding=
s/mfd/stm32f7-rcc.h
> > index a90f3613c584..ba5cb7456ee4 100644
> > --- a/include/dt-bindings/mfd/stm32f7-rcc.h
> > +++ b/include/dt-bindings/mfd/stm32f7-rcc.h
> > @@ -107,6 +107,7 @@
> >  #define STM32F7_RCC_APB2_SAI1                22
> >  #define STM32F7_RCC_APB2_SAI2                23
> >  #define STM32F7_RCC_APB2_LTDC                26
> > +#define STM32F7_RCC_APB2_DSI         27
> >
> >  #define STM32F7_APB2_RESET(bit)      (STM32F7_RCC_APB2_##bit + (0x24 *=
 8))
> >  #define STM32F7_APB2_CLOCK(bit)      (STM32F7_RCC_APB2_##bit + 0xA0)
>
> --
> Lee Jones [=E6=9D=8E=E7=90=BC=E6=96=AF]
> Linaro Services Technical Lead
> Linaro.org =E2=94=82 Open source software for ARM SoCs
> Follow Linaro: Facebook | Twitter | Blog

On Mon, Apr 27, 2020 at 9:49 AM Lee Jones <lee.jones@linaro.org> wrote:
>
> On Fri, 24 Apr 2020, Adrian Pop wrote:
>
> > Add missing clock.
> >
> > Signed-off-by: Adrian Pop <pop.adrian61@gmail.com>
> > ---
> >  include/dt-bindings/mfd/stm32f7-rcc.h | 1 +
> >  1 file changed, 1 insertion(+)
>
> I assume patch 2 depends on this?
>
> If so, where is it?  Why isn't it in my inbox?
>
> > diff --git a/include/dt-bindings/mfd/stm32f7-rcc.h b/include/dt-binding=
s/mfd/stm32f7-rcc.h
> > index a90f3613c584..ba5cb7456ee4 100644
> > --- a/include/dt-bindings/mfd/stm32f7-rcc.h
> > +++ b/include/dt-bindings/mfd/stm32f7-rcc.h
> > @@ -107,6 +107,7 @@
> >  #define STM32F7_RCC_APB2_SAI1                22
> >  #define STM32F7_RCC_APB2_SAI2                23
> >  #define STM32F7_RCC_APB2_LTDC                26
> > +#define STM32F7_RCC_APB2_DSI         27
> >
> >  #define STM32F7_APB2_RESET(bit)      (STM32F7_RCC_APB2_##bit + (0x24 *=
 8))
> >  #define STM32F7_APB2_CLOCK(bit)      (STM32F7_RCC_APB2_##bit + 0xA0)
>
> --
> Lee Jones [=E6=9D=8E=E7=90=BC=E6=96=AF]
> Linaro Services Technical Lead
> Linaro.org =E2=94=82 Open source software for ARM SoCs
> Follow Linaro: Facebook | Twitter | Blog