Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp3222943ybz; Mon, 27 Apr 2020 12:09:58 -0700 (PDT) X-Google-Smtp-Source: APiQypJof4XeNGjTUP76dZuweHqWGKt8jsvwBoq6Ds7ipTXWJobt95Xr2hvbLmEjRQMmcz7MA535 X-Received: by 2002:a50:9e8f:: with SMTP id a15mr19152445edf.68.1588014598792; Mon, 27 Apr 2020 12:09:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588014598; cv=none; d=google.com; s=arc-20160816; b=0gGpVZhuPZzzquISiRNrO18C+/7N0dLPa7RsukxdpaWnPmy0oZo0kbZUTyFuxLoks+ uuTNwVi/f3F2+2SlWuZm90u2sIYtBA61RFfLu+F2FcFBn47/S0TUvjWyd5aUcNZTnh/M DBtOWkbmTdAw8kIJqSjhFly1SKTN4iOV2zTrYAQ1BnOgsFiN3IdcsMIj7zBSq1SJ7kXF op+lukhJFmQCyXy8q1Q/sIDe8Fa/fdG9v05vFllliYa6pFfztLseX9CqTB04iI30NDPM TUzhF6kewzdzYnXnAoEYyWTd8lCxUDnoIL3LUMaQUeO0wioL6VbLkLObyl2tVPs8PUzt LkmQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=JRoV70XJ82qy2NPzofnMtyf3xYGiNYtE3lKwK7ddThs=; b=LWWbBIoKqtkLYQDoOnhpRrjQw+T4UBLmeo7u6Dur40rFZK3c11E2mMa6ovi/IkJlbv XBqzc29jzpXYOkKg4IuChjx34owED5Lw4UmaL3wvdgSOkGVYHwwBLQpxpZB4/iXjQrPy 2JjcjJEPqORlVIPkIyhs/C2zXBeDyvxYW5+XAFa6qY1uK487Sl2uAJQSDu+XrpNakGx2 qq4ngbTGZITKgqpBu8skS9IF3W16bVcoF6SHgfK7YIzpHgH+E51iEd0WhFy69YDMUyw6 jx40uhNPkbml2KGwLcOKAAc/6Y76nMLQPCxiQ7oMpzUOPqEtPmqgHqg9iem6A7BhJFxu r2yw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id da12si247601edb.439.2020.04.27.12.09.35; Mon, 27 Apr 2020 12:09:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726682AbgD0TIC (ORCPT + 99 others); Mon, 27 Apr 2020 15:08:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49860 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726315AbgD0TIC (ORCPT ); Mon, 27 Apr 2020 15:08:02 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4A72FC0610D5; Mon, 27 Apr 2020 12:08:02 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id A35C015D59E0D; Mon, 27 Apr 2020 12:08:01 -0700 (PDT) Date: Mon, 27 Apr 2020 12:08:00 -0700 (PDT) Message-Id: <20200427.120800.2048743248471906857.davem@davemloft.net> To: christophe.jaillet@wanadoo.fr Cc: fthain@telegraphics.com.au, tsbogend@alpha.franken.de, jgarzik@pobox.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] net/sonic: Fix a resource leak in an error handling path in 'jazz_sonic_probe()' From: David Miller In-Reply-To: <20200427061803.53857-1-christophe.jaillet@wanadoo.fr> References: <20200427061803.53857-1-christophe.jaillet@wanadoo.fr> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 27 Apr 2020 12:08:01 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Christophe JAILLET Date: Mon, 27 Apr 2020 08:18:03 +0200 > A call to 'dma_alloc_coherent()' is hidden in 'sonic_alloc_descriptors()', > called from 'sonic_probe1()'. > > This is correctly freed in the remove function, but not in the error > handling path of the probe function. > Fix it and add the missing 'dma_free_coherent()' call. > > While at it, rename a label in order to be slightly more informative. > > Fixes: efcce839360f ("[PATCH] macsonic/jazzsonic network drivers update") > Signed-off-by: Christophe JAILLET Applied, thanks.