Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp3223654ybz; Mon, 27 Apr 2020 12:10:45 -0700 (PDT) X-Google-Smtp-Source: APiQypIXQjA6gIZjJZ5jS88wfjvM+hI5oK+4qCXISpyMTJgQa0egUdbIZI9wXx0MmU0jVcZ2fWZn X-Received: by 2002:a50:9f85:: with SMTP id c5mr19932783edf.278.1588014645249; Mon, 27 Apr 2020 12:10:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588014645; cv=none; d=google.com; s=arc-20160816; b=Am8zJ0phXMEWHICo1jzCO0OFRH3Bz4j4MKCh9wz+TlOVUago9FOX88gt/snEvytTD2 /L5jF2uJ3KXQGIfiDn6rweUBvnnwthKxeHKVtf9894cefOnR0tBGmAMxsoAk8Tj6g2Sx ypiBtaCYPlY9SNU3CQlyYbkrT/tyK2Ve9ypPFm5k38ynYwxQ74yFU813FVPp2K4DVXeW wM7S+RYQJ1no6omCFqwNioDlmO4Ym0mL8PRIYyeXD17GfXNX2lSWe/cRajhpVMX7vcBZ k6KWcYju/xZvPL3NGZtteCUGT7CWe3HY+bYkOmspcKuiXiEsGGVtrJjvIZ7W9OdDljO3 II/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:from:references:cc:to:subject:dkim-signature; bh=/58bSLWDDjzcT2tctTT4jLGloRKm4Hg0aZzs/rxPU5M=; b=jgUxpwVK0VL362ZO7iIdT/J2LzopuOkXMJnmgCZ5x44XoxtbPqk566N44eq+pY+WK+ 0LetWyLoRnlaQ8te9pUwg+beXIOAfxMLWJMmum2xnzVzljV/R8xP5zXhbTZu3dp4EQt9 Rd4okga/W9jJdZZCr3VcSey+sQ1niPkH/FSqPXH18b0Uvs3RdG3v+nYGsaAMM6QyTyjn cTn94qQWr/R6w28bNdoUEiIUPHcO1FovLQvHHEyK8ACxh21NqmRY6Xc1TLDVpbw48MGt L9wBeqJcgsqqUU6rgjIvHhA1UANnF1zktG38LNhW7odz0tq31S8MxPJOxiO3n5fx3Ml+ U9pA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@embeddedor.com header.s=default header.b=IX5ru19H; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t24si275639ejb.144.2020.04.27.12.10.20; Mon, 27 Apr 2020 12:10:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@embeddedor.com header.s=default header.b=IX5ru19H; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726576AbgD0TGU (ORCPT + 99 others); Mon, 27 Apr 2020 15:06:20 -0400 Received: from gateway23.websitewelcome.com ([192.185.48.104]:13612 "EHLO gateway23.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726549AbgD0TGU (ORCPT ); Mon, 27 Apr 2020 15:06:20 -0400 Received: from cm11.websitewelcome.com (cm11.websitewelcome.com [100.42.49.5]) by gateway23.websitewelcome.com (Postfix) with ESMTP id 417F69EA3 for ; Mon, 27 Apr 2020 14:06:19 -0500 (CDT) Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with SMTP id T959j8qacSl8qT959jYNj6; Mon, 27 Apr 2020 14:06:19 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=embeddedor.com; s=default; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=/58bSLWDDjzcT2tctTT4jLGloRKm4Hg0aZzs/rxPU5M=; b=IX5ru19HgOo45+YLXdG5xp7hn+ jtd/UfqU9FzoYjS1ov7orVAZNooQfanRT7IHGrTmPOuMsBkD+BCfV00LuNjMypmZM7p+BDkt/ONfT 2sUUZKBY7tvHv2WCscmUQt88qZUpBqEDdhra1BNVLtOx8YpoV7Xu+xv76ykfiY74Fi4JZjJwXmrf6 IFPDG2cvWUxhW7vfw3+anQ9gVAyFhJJcW5+DVTVcVe8qXxkqt/gcTp1ydNM7dZs/J5OFdU4YZWIbD +lhrSIKgyBbE2KoPx7QYXDmY+ysLLAv7t1aLQin7uq7TFx6XddIpTYkgZrCUBGgeSD3HHJL1XiTUq A+jRTUPA==; Received: from [201.162.241.110] (port=23674 helo=[192.168.43.132]) by gator4166.hostgator.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.92) (envelope-from ) id 1jT958-000euX-NC; Mon, 27 Apr 2020 14:06:18 -0500 Subject: Re: [PATCH 2/3] mtd: lpddr: Replace printk with pr_notice To: Joe Perches , linux-kernel@vger.kernel.org Cc: Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , linux-mtd@lists.infradead.org References: From: "Gustavo A. R. Silva" Autocrypt: addr=gustavo@embeddedor.com; keydata= xsFNBFssHAwBEADIy3ZoPq3z5UpsUknd2v+IQud4TMJnJLTeXgTf4biSDSrXn73JQgsISBwG 2Pm4wnOyEgYUyJd5tRWcIbsURAgei918mck3tugT7AQiTUN3/5aAzqe/4ApDUC+uWNkpNnSV tjOx1hBpla0ifywy4bvFobwSh5/I3qohxDx+c1obd8Bp/B/iaOtnq0inli/8rlvKO9hp6Z4e DXL3PlD0QsLSc27AkwzLEc/D3ZaqBq7ItvT9Pyg0z3Q+2dtLF00f9+663HVC2EUgP25J3xDd 496SIeYDTkEgbJ7WYR0HYm9uirSET3lDqOVh1xPqoy+U9zTtuA9NQHVGk+hPcoazSqEtLGBk YE2mm2wzX5q2uoyptseSNceJ+HE9L+z1KlWW63HhddgtRGhbP8pj42bKaUSrrfDUsicfeJf6 m1iJRu0SXYVlMruGUB1PvZQ3O7TsVfAGCv85pFipdgk8KQnlRFkYhUjLft0u7CL1rDGZWDDr NaNj54q2CX9zuSxBn9XDXvGKyzKEZ4NY1Jfw+TAMPCp4buawuOsjONi2X0DfivFY+ZsjAIcx qQMglPtKk/wBs7q2lvJ+pHpgvLhLZyGqzAvKM1sVtRJ5j+ARKA0w4pYs5a5ufqcfT7dN6TBk LXZeD9xlVic93Ju08JSUx2ozlcfxq+BVNyA+dtv7elXUZ2DrYwARAQABzSxHdXN0YXZvIEEu IFIuIFNpbHZhIDxndXN0YXZvQGVtYmVkZGVkb3IuY29tPsLBfQQTAQgAJwUCWywcDAIbIwUJ CWYBgAULCQgHAgYVCAkKCwIEFgIDAQIeAQIXgAAKCRBHBbTLRwbbMZ6tEACk0hmmZ2FWL1Xi l/bPqDGFhzzexrdkXSfTTZjBV3a+4hIOe+jl6Rci/CvRicNW4H9yJHKBrqwwWm9fvKqOBAg9 obq753jydVmLwlXO7xjcfyfcMWyx9QdYLERTeQfDAfRqxir3xMeOiZwgQ6dzX3JjOXs6jHBP cgry90aWbaMpQRRhaAKeAS14EEe9TSIly5JepaHoVdASuxklvOC0VB0OwNblVSR2S5i5hSsh ewbOJtwSlonsYEj4EW1noQNSxnN/vKuvUNegMe+LTtnbbocFQ7dGMsT3kbYNIyIsp42B5eCu JXnyKLih7rSGBtPgJ540CjoPBkw2mCfhj2p5fElRJn1tcX2McsjzLFY5jK9RYFDavez5w3lx JFgFkla6sQHcrxH62gTkb9sUtNfXKucAfjjCMJ0iuQIHRbMYCa9v2YEymc0k0RvYr43GkA3N PJYd/vf9vU7VtZXaY4a/dz1d9dwIpyQARFQpSyvt++R74S78eY/+lX8wEznQdmRQ27kq7BJS R20KI/8knhUNUJR3epJu2YFT/JwHbRYC4BoIqWl+uNvDf+lUlI/D1wP+lCBSGr2LTkQRoU8U 64iK28BmjJh2K3WHmInC1hbUucWT7Swz/+6+FCuHzap/cjuzRN04Z3Fdj084oeUNpP6+b9yW e5YnLxF8ctRAp7K4yVlvA87BTQRbLBwMARAAsHCE31Ffrm6uig1BQplxMV8WnRBiZqbbsVJB H1AAh8tq2ULl7udfQo1bsPLGGQboJSVN9rckQQNahvHAIK8ZGfU4Qj8+CER+fYPp/MDZj+t0 DbnWSOrG7z9HIZo6PR9z4JZza3Hn/35jFggaqBtuydHwwBANZ7A6DVY+W0COEU4of7CAahQo 5NwYiwS0lGisLTqks5R0Vh+QpvDVfuaF6I8LUgQR/cSgLkR//V1uCEQYzhsoiJ3zc1HSRyOP otJTApqGBq80X0aCVj1LOiOF4rrdvQnj6iIlXQssdb+WhSYHeuJj1wD0ZlC7ds5zovXh+FfF l5qH5RFY/qVn3mNIVxeO987WSF0jh+T5ZlvUNdhedGndRmwFTxq2Li6GNMaolgnpO/CPcFpD jKxY/HBUSmaE9rNdAa1fCd4RsKLlhXda+IWpJZMHlmIKY8dlUybP+2qDzP2lY7kdFgPZRU+e zS/pzC/YTzAvCWM3tDgwoSl17vnZCr8wn2/1rKkcLvTDgiJLPCevqpTb6KFtZosQ02EGMuHQ I6Zk91jbx96nrdsSdBLGH3hbvLvjZm3C+fNlVb9uvWbdznObqcJxSH3SGOZ7kCHuVmXUcqoz ol6ioMHMb+InrHPP16aVDTBTPEGwgxXI38f7SUEn+NpbizWdLNz2hc907DvoPm6HEGCanpcA EQEAAcLBZQQYAQgADwUCWywcDAIbDAUJCWYBgAAKCRBHBbTLRwbbMdsZEACUjmsJx2CAY+QS UMebQRFjKavwXB/xE7fTt2ahuhHT8qQ/lWuRQedg4baInw9nhoPE+VenOzhGeGlsJ0Ys52sd XvUjUocKgUQq6ekOHbcw919nO5L9J2ejMf/VC/quN3r3xijgRtmuuwZjmmi8ct24TpGeoBK4 WrZGh/1hAYw4ieARvKvgjXRstcEqM5thUNkOOIheud/VpY+48QcccPKbngy//zNJWKbRbeVn imua0OpqRXhCrEVm/xomeOvl1WK1BVO7z8DjSdEBGzbV76sPDJb/fw+y+VWrkEiddD/9CSfg fBNOb1p1jVnT2mFgGneIWbU0zdDGhleI9UoQTr0e0b/7TU+Jo6TqwosP9nbk5hXw6uR5k5PF 8ieyHVq3qatJ9K1jPkBr8YWtI5uNwJJjTKIA1jHlj8McROroxMdI6qZ/wZ1ImuylpJuJwCDC ORYf5kW61fcrHEDlIvGc371OOvw6ejF8ksX5+L2zwh43l/pKkSVGFpxtMV6d6J3eqwTafL86 YJWH93PN+ZUh6i6Rd2U/i8jH5WvzR57UeWxE4P8bQc0hNGrUsHQH6bpHV2lbuhDdqo+cM9eh GZEO3+gCDFmKrjspZjkJbB5Gadzvts5fcWGOXEvuT8uQSvl+vEL0g6vczsyPBtqoBLa9SNrS VtSixD1uOgytAP7RWS474w== Message-ID: <67c4b34d-019d-e4c9-ebd2-3a8477470048@embeddedor.com> Date: Mon, 27 Apr 2020 14:10:36 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 201.162.241.110 X-Source-L: No X-Exim-ID: 1jT958-000euX-NC X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: ([192.168.43.132]) [201.162.241.110]:23674 X-Source-Auth: gustavo@embeddedor.com X-Email-Count: 8 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/27/20 14:01, Joe Perches wrote: > On Mon, 2020-04-27 at 14:03 -0500, Gustavo A. R. Silva wrote: >> pr_notice is preferred over printk. > > So is coalescing formats > > ? diff --git a/include/linux/mtd/pfow.h b/include/linux/mtd/pfow.h > [] >> @@ -127,31 +127,31 @@ static inline void print_drs_error(unsigned dsr) >> int prog_status = (dsr & DSR_RPS) >> 8; >> >> if (!(dsr & DSR_AVAILABLE)) >> - printk(KERN_NOTICE"DSR.15: (0) Device not Available\n"); >> + pr_notice("DSR.15: (0) Device not Available\n"); >> if ((prog_status & 0x03) == 0x03) >> - printk(KERN_NOTICE"DSR.9,8: (11) Attempt to program invalid " >> + pr_notice("DSR.9,8: (11) Attempt to program invalid " >> "half with 41h command\n"); > > pr_notice("DSR.9,8: (11) Attempt to program invalid half with 41h command\n"); > I didn't want to mess with the rest of format, because some maintainers don't like that. If Miquel is OK with that, I can fix that up, too. Thanks -- Gustavo