Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 27 Apr 2020 12:26:06 -0700
From:   Andrew Morton <akpm@linux-foundation.org>
To:     Souptick Joarder <jrdr.linux@gmail.com>
Cc:     linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/gup.c: Updating the documentation
Message-Id: <20200427122606.dc29c381f6da47831a40d365@linux-foundation.org>
In-Reply-To: <1588013630-4497-1-git-send-email-jrdr.linux@gmail.com>
References: <1588013630-4497-1-git-send-email-jrdr.linux@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, 28 Apr 2020 00:23:50 +0530 Souptick Joarder <jrdr.linux@gmail.com> wrote:

> This patch is an attempt to update the documentation.
> 
> * Adding / removing extra * based on type of function
> static / global.

I don't think so, unless this is a new kerneldoc convention?

> --- a/mm/gup.c
> +++ b/mm/gup.c
> @@ -722,7 +722,7 @@ static struct page *follow_p4d_mask(struct vm_area_struct *vma,
>  	return follow_pud_mask(vma, address, p4d, flags, ctx);
>  }
>  
> -/**
> +/*
>   * follow_page_mask - look up a page descriptor from a user-virtual address
>   * @vma: vm_area_struct mapping @address
>   * @address: virtual address to look up

/** indicates that the comment is in kerneldoc form, not that it has
static scope?