Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp3286863ybz; Mon, 27 Apr 2020 13:21:56 -0700 (PDT) X-Google-Smtp-Source: APiQypLGmMzWMOQIdzxhXVP2HixJb71YeVLeHBiHZAJhnChVOxF7vihHwrgSbTu3gC3jn2cZfh3G X-Received: by 2002:a17:906:9518:: with SMTP id u24mr21625281ejx.320.1588018916113; Mon, 27 Apr 2020 13:21:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588018916; cv=none; d=google.com; s=arc-20160816; b=HDe6dUcy4YbYE3ueELL93kyorAQmVr/Zp64tt2OWkZJ8R3wws01pkfgCwz3UmcTalu JLV/3I53c7vchhWVGHjyEGCjmU9/SwtAD3uhQpDa+Xg7HRmmpTvhyzYyDy8GacSXCGCx S919DMPEKHLTJ03RiaAqRlsstguBuGtAvSnTsMfL+X9kyzNxJ62d0LbiYXR8br192JtY tkJaciAtjZYMIMNDlUI/UFDv3cMSHoc75b3MMQxHB6mByzcUb6LsJKID/cejS+IWDRQ0 5Q0lbdA9eEw9FAXlmWrwMcGQ6qXTfhXA8Yhth1Lf3NnIOLhnnYm2xx/nScBxUr/BKz0o Fv/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=MOhEUODc6IWJo+uz8WOtGJZo0/T+F1D6cLgkpyjESgk=; b=rcWdkN3zIuG7U0c2b9vk3LiqhzG3e5qeIGCWZ72saMpKfqUxQW6chKUWrlw1G7Ai1J 0xCiypisbSwlvJXdQzggS37Th9yjeV070jGhGqiRgvqbQBCiLhbkblf3XPTEVwRA42VM QtfaFBHoi5Y4vN8CYhGNIQJQSpuxObui1pdZFfSOmDa1Kit5/QaO1jnijP77V9XtVOKK kzziof/3/czkHJf1dm5RgYBYOyNY/wMvuoh1XeMZkK8EdXpbRyqxpXfEMiX/fWgEmXQU +SdSTrivk90SgqcBPZALpTLkb/1C3Nc4+aL/cEnNb3fNQJS7JCoOmbcOeQrlELEt+oSs O5qQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="0dPVwJ/H"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d14si370044edv.332.2020.04.27.13.21.32; Mon, 27 Apr 2020 13:21:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="0dPVwJ/H"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726519AbgD0USF (ORCPT + 99 others); Mon, 27 Apr 2020 16:18:05 -0400 Received: from mail.kernel.org ([198.145.29.99]:37860 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726285AbgD0USE (ORCPT ); Mon, 27 Apr 2020 16:18:04 -0400 Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id AB8ED2072D; Mon, 27 Apr 2020 20:18:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588018684; bh=FZznVs7DKImH4bMp84GuK30NCRT+ks2QZb0zw61Aw2o=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=0dPVwJ/H9B7uUoDHVQh+JzhGMmouLB2JEnhplDQk7I3xuAgcbSFK60H1piEfCx5Sx t+jKABLjlMrQXuoJB1Wv7UdopSfsHYSYtmSlzWb93RhaIDNLpcyXt7Avmd+0pazZfN HbeEsAjiXXS9v7hdBuMksmtrvhaQ+taOUTUIOuQQ= Date: Mon, 27 Apr 2020 13:18:02 -0700 From: Andrew Morton To: Mike Kravetz Cc: Sandipan Das , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, sparclinux@vger.kernel.org, linux-doc@vger.kernel.org, Catalin Marinas , Will Deacon , Benjamin Herrenschmidt , Paul Mackerras , Paul Walmsley , Palmer Dabbelt , Albert Ou , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , "David S.Miller" , Thomas Gleixner , Ingo Molnar , Dave Hansen , Jonathan Corbet , Longpeng , Christophe Leroy , Randy Dunlap , Mina Almasry , Peter Xu , Nitesh Narayan Lal Subject: Re: [PATCH v3 2/4] hugetlbfs: move hugepagesz= parsing to arch independent code Message-Id: <20200427131802.3d132055a59535a0e6780e9f@linux-foundation.org> In-Reply-To: References: <20200417185049.275845-1-mike.kravetz@oracle.com> <20200417185049.275845-3-mike.kravetz@oracle.com> <7583dfcc-62d8-2a54-6eef-bcb4e01129b3@gmail.com> <5a380060-38db-b690-1003-678ca0f28f07@oracle.com> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 27 Apr 2020 12:09:47 -0700 Mike Kravetz wrote: > Previously, a check for hugepages_supported was added before processing > hugetlb command line parameters. On some architectures such as powerpc, > hugepages_supported() is not set to true until after command line > processing. Therefore, no hugetlb command line parameters would be > accepted. > > Remove the additional checks for hugepages_supported. In hugetlb_init, > print a warning if !hugepages_supported and command line parameters were > specified. This applies to [4/4] instead of fixing [2/4]. I guess you'll straighten that out in v4? btw, was http://lkml.kernel.org/r/CADYN=9Koefrq9H1Y82Q8nMNbeyN4tzhEfvDu5u=sVFjFZCYorA@mail.gmail.com addressed?