Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <fdcc8aa5a506ba9c6a3e6e68a7147161424985bf.camel@perches.com>
Subject: Re: [PATCH] xfs: Use the correct style for SPDX License Identifier
From:   Joe Perches <joe@perches.com>
To:     Linus Torvalds <torvalds@linux-foundation.org>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "Darrick J. Wong" <darrick.wong@oracle.com>,
        Kate Stewart <kstewart@linuxfoundation.org>,
        Nishad Kamdar <nishadkamdar@gmail.com>,
        Uwe =?ISO-8859-1?Q?Kleine-K=F6nig?= 
        <u.kleine-koenig@pengutronix.de>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        linux-xfs <linux-xfs@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Date:   Mon, 27 Apr 2020 13:38:58 -0700
In-Reply-To: <CAHk-=wgN=Ox112_O=GQ-kwMxYduix9gZFsr1GXXJWLpDpNDm5g@mail.gmail.com>
References: <20200425133504.GA11354@nishad> <20200427155617.GY6749@magnolia>
         <20200427172959.GB3936841@kroah.com>
         <515362d10c06567f35f0d5b7c3f2e121769fb04b.camel@perches.com>
         <20200427174611.GA4035548@kroah.com>
         <791a97d5d4dfd11af533a0bbd6ae27d1a2d479ee.camel@perches.com>
         <20200427183629.GA20158@kroah.com>
         <16b209d0b0c8034db62f8d4d0a260a00f0aa5d5e.camel@perches.com>
         <CAHk-=wgN=Ox112_O=GQ-kwMxYduix9gZFsr1GXXJWLpDpNDm5g@mail.gmail.com>
Content-Type: text/plain; charset="ISO-8859-1"
User-Agent: Evolution 3.36.1-2 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, 2020-04-27 at 12:40 -0700, Linus Torvalds wrote:
> On Mon, Apr 27, 2020 at 11:59 AM Joe Perches <joe@perches.com> wrote:
> > There's no real reason not to prefer the latest versions
> > over the deprecated ones.
> 
> Joe, your pedantic approach is really hard to work with. Please work on it.

License text especially _should_ be pedantic and precise.

> The fact is, there *is * a reason to avoid the pedantic "change to new
> version" - pointless churn.

Have you *looked* at this proposed change?

It just changes // SPDX comments to /* */ in .h files.

It's generically useless churn as using the // style in .h files
was only for old and now unsupported compiler versions.

> We have a lot of the original style spdx markers, because those are
> what we started with. And changing them is pointless.

You and I (and apparently the SPDX group too as they deprecated it)
disagree a bit here.

> I know you love your scripts to change things around, but to everybody
> else it tends to be just extra work and noise.

Piecemeal changes aren't great.

Scripted changes can be very useful and I believe they
are significantly underutilized in this source tree.

cheers, Joe