Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: +Ga1UgSlbW8FPEo41r0AB+0ny+BMs/j+BhdV5K/GKyZvgJTeHyl8XbW+ECy8uhK/gJ4v3iBORE
 9OA7NX+dLfAg==
IronPort-SDR: WUy7Ml9OpMwqewlj0CA3nQMy8vgjApChiB0WwhLzBf1Y/8ICVCC3IobYn+MtLLcveRZiY6VbmU
 X747U76pT5qA==
Date:   Mon, 27 Apr 2020 19:47:44 -0700
From:   Andi Kleen <ak@linux.intel.com>
To:     Stephane Eranian <eranian@google.com>
Cc:     linux-kernel@vger.kernel.org, peterz@infradead.org, mingo@elte.hu,
        acme@redhat.com, jolsa@redhat.com, irogers@google.com,
        kan.liang@intel.com
Subject: Re: [PATCH] perf/script: remove extraneous newline in
 perf_sample__fprintf_regs()
Message-ID: <20200428024744.GA703870@tassilo.jf.intel.com>
References: <20200418231908.152212-1-eranian@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200418231908.152212-1-eranian@google.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sat, Apr 18, 2020 at 04:19:08PM -0700, Stephane Eranian wrote:
> When printing iregs, there was a double newline printed because
> perf_sample__fprintf_regs() was printing its own and then at the
> end of all fields, perf script was adding one.
> This was causing blank line in the output:

I don't think the patch is quite correct because there could be
other fields after it, and they need to be separated by a 
new line too.

e.g. i suspect if someone prints iregs,uregs or iregs,brstack
or something else that is printed in process_event after *regs
you would get garbled output.

So you have to track if the newline is needed or not.

-Andi