Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp3618867ybz; Mon, 27 Apr 2020 19:54:02 -0700 (PDT) X-Google-Smtp-Source: APiQypJoWvXMH1nGx7V+010P4FThsqWHw1klajw3AGT3RA2GXmPXbXGH0rhsQ6HV4lMfISFFNX4y X-Received: by 2002:a17:906:2acf:: with SMTP id m15mr21766137eje.173.1588042442421; Mon, 27 Apr 2020 19:54:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588042442; cv=none; d=google.com; s=arc-20160816; b=u1Uk9Iv0q885K/FJLT7Nuij8y3JC0dEmVKSI7dfLx9KhhmCWEtDgVLjPvRMXePPcpF 4tc3kvtK2uJKh9EDaNq2oc4/RXmUzI2jfDZq2ZBHUDrVd3+ZtS4wlDNfZDKl9pTRgkfW 37vsLbxqbROn3dlaKTjnyPuSHcYdPPxkhJu+onXZoJ96CdfVkSBF7ncjDNZnxMJqWf62 wL0W6qfXqIFHzHjXiuqItwQUJM6q3H1MkXdtc5oWvZbdKTtg6cVwVAjS0wzNulZY4DU1 3hjwY7rNxIZKGmE8viAEyPWOoLBpobeRofXaIzTYB7+fyciJWmn/hkhvR96/9jKrQiIF 5PZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:date:cc:to:from:subject:message-id :dkim-signature; bh=rmHu9+RzAsV0zXEOYPmNsBI/oYLRLrzcV0fRDGVIGhI=; b=lrwU3Q6WkjzO99mckfWdWfqlMq69DI4a9sjiEzsT2nAxUTzPp2ks6QQeilvOMa37zB 163q+TZOpSsXLvKjljSClQBGOb4ntmnz7kCaWlEDTMYtFuDKnK0g3clzXBDhehMCanrf U6tQ5Mx5NwaoZBP9J/q1Yl7a4s2/Gr1qKCoflWwrH28WaeBktMZ2EU3BHG1tD8lGOrEp /vakdy5+SIy7B7a/g0ibFJL2kGLHFXcQwCg16MKCDVEyDTlyMI3zSaJmIi8KDDqMYCtR bA81DnTjKCU7MS14nqpX4T8cEvY1zt+Q0WhIpSnPcRcMyeFGLvWjZK9ra7+TNxxGUCDA semw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ozlabs.org header.s=201707 header.b=I8N3xVH+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ozlabs.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r3si891968edc.405.2020.04.27.19.53.39; Mon, 27 Apr 2020 19:54:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@ozlabs.org header.s=201707 header.b=I8N3xVH+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ozlabs.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726343AbgD1CwC (ORCPT + 99 others); Mon, 27 Apr 2020 22:52:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37588 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726264AbgD1CwC (ORCPT ); Mon, 27 Apr 2020 22:52:02 -0400 Received: from ozlabs.org (ozlabs.org [IPv6:2401:3900:2:1::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 04C95C03C1A9; Mon, 27 Apr 2020 19:52:02 -0700 (PDT) Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 49B5lL0BjJz9sRY; Tue, 28 Apr 2020 12:51:56 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ozlabs.org; s=201707; t=1588042319; bh=r5Tvdog+oekyzSzSlTc7HgiNfwz4L1TcZBGr5ZE+R9Y=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=I8N3xVH+hQtt50jVi6Jl7REeiYhE+Ms2nP1zfHzGZCOaJxtALGlwrn+1EedXTMiI/ 5FhMU67SHJd2vI0nhihcCftizAnuSUxBuMXwXIKH63+aeCRDClv7C0oO3NNphbTbUw gO3zmC+2mDlaFpvp24+UUVBJNqeZ/w56gwe29raW3TFZq1Eq3JDGF8Q8MSs5TVl8bG XmjXpEADeFeBz3Zkrf9sfMtKLciDNIczRo3QZJ1LU8MHD2CIbJDfCJJn/DXu4dxxsR A0g8HIJXHRNy97HlStw9iDlAvS99j3d6NIz39OKFty1f5KF5FMmDorhb2CZhu2smcD LnhwwQ0e38M8Q== Message-ID: Subject: Re: [PATCH 1/5] powerpc/spufs: simplify spufs core dumping From: Jeremy Kerr To: Al Viro , Christoph Hellwig Cc: Andrew Morton , Linus Torvalds , Arnd Bergmann , "Eric W . Biederman" , linuxppc-dev@lists.ozlabs.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Date: Tue, 28 Apr 2020 10:51:56 +0800 In-Reply-To: <20200427204953.GY23230@ZenIV.linux.org.uk> References: <20200427200626.1622060-1-hch@lst.de> <20200427200626.1622060-2-hch@lst.de> <20200427204953.GY23230@ZenIV.linux.org.uk> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Al & Christoph, > Again, this really needs fixing. Preferably - as a separate commit > preceding this series, so that it could be > backported. simple_read_from_buffer() is a blocking operation. I'll put together a patch that fixes this. Christoph: I'll do it in a way that matches your changes to the _read functions, so hopefully those hunks would just drop from your change, leaving only the _dump additions. Would that work? Cheers, Jeremy