Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v2] module: Allow to disable modsign in kernel cmdline
To:     Randy Dunlap <rdunlap@infradead.org>, jeyu@kernel.org,
        corbet@lwn.net, mchehab+samsung@kernel.org, tglx@linutronix.de,
        akpm@linux-foundation.org, gregkh@linuxfoundation.org,
        pawan.kumar.gupta@linux.intel.com, jgross@suse.com
Cc:     linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org
References: <20200428050523.47253-1-tianjia.zhang@linux.alibaba.com>
 <aff03dbb-a1a3-c95e-1c24-60279b14970a@infradead.org>
From:   Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
Message-ID: <aecb37fd-e99e-c6e2-ac80-ccf1ae2b0295@linux.alibaba.com>
Date:   Tue, 28 Apr 2020 14:01:37 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.7.0
MIME-Version: 1.0
In-Reply-To: <aff03dbb-a1a3-c95e-1c24-60279b14970a@infradead.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 2020/4/28 13:52, Randy Dunlap wrote:
> Hi,
> 
> On 4/27/20 10:05 PM, Tianjia Zhang wrote:
>> diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
>> index 7bc83f3d9bdf..00ed7566959f 100644
>> --- a/Documentation/admin-guide/kernel-parameters.txt
>> +++ b/Documentation/admin-guide/kernel-parameters.txt
>> @@ -3190,6 +3190,12 @@
>>   	noirqdebug	[X86-32] Disables the code which attempts to detect and
>>   			disable unhandled interrupt sources.
>>   
>> +	no_modsig_enforce
>> +			[KNL] When CONFIG_MODULE_SIG_FORCE is set, this option
>> +			allows to disable modsign completely at the beginning.
>> +			This means that modules without (valid) signatures will
>> +			success to load.
> 
> 			succeed to load.
> 
> 			succeed in loading.
> 
> 			load successfully.
> I prefer this one.....  ^^^^^^^^^^^^^^^^^^^^^
> 
> 			be loaded successfully.
> 
> 
>> +
>>   	no_timer_check	[X86,APIC] Disables the code which tests for
>>   			broken timer IRQ sources.
>>   
> 
> thanks.
> 

v3 patch has been submitted, thank you for your suggestion.

Thanks,
Tianjia