Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp3858783ybz; Tue, 28 Apr 2020 01:29:35 -0700 (PDT) X-Google-Smtp-Source: APiQypJNiajt2+lLmfqqcuk6tE6Q4YceTtiGk/suf1RBJNUSQvn6ZuyTk9avDSg0DToiyUwr627K X-Received: by 2002:a17:906:310e:: with SMTP id 14mr24443998ejx.177.1588062575701; Tue, 28 Apr 2020 01:29:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588062575; cv=none; d=google.com; s=arc-20160816; b=oN8PuhbG4fSdaLeiMekYKieqnFX7DFRIbpsotaR4P4PyTA0TyqQoj4kpQ9C6niK3lI 2OcfPMLKTsNDt9tcGOztQwn3IPtPSOAhJpEr0XkRJ9LwEBDdxb/4QUOTsJWTDoysYWRp RUEG/12OVmcTYSCuHBXjodmSB1DYViFbYYH8V7twWaBbWImkiG8b3Ge77OzO35/JqMSe bqwJ5bQ65eBCwTkTIc/oWvDLodzsEcJei/a9oEX727GOfdEwdwrmqjjzhRXu3UIGUP7J 3+9KtW5MTDdNq2yrQ2Hvhd2F9VE74lmFc9USgK7pQsh8Y7HJvZe6TfnWExA6myWYX9By Q20g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=4KAKGMOQtixgIHT8OLI5/B0nihDoY8npPWOEhk/HD9M=; b=r8uQBAncp8U5CmJqBv80u9Elujb7DwBBvxlwz8k9wdP29Dvfh0bmCjNpP8KUYZ0bzj EfvHjqPzeJmNVLIKAysPtht0gmHI4KXNHp8sqYOx7GHQNvgNgtgjzQvHPUIRuEZ+u6Bh LMMNy2xfiXuIPRNSKf3WgEZW+6qe4dIMG6eB2LX1CmnGhpSYuzAxanV08dZ9Ey44RmMk DaAsVJf2l7jM4skhTVUBiavmaveAqRjxA6TAAk6td+Jz0ZKgu+46Qkf/Z/6qff/VE6vQ FD3md9jbNd2uZXekppPYljISrFxMFrr7Pa45Mzlqge+wAvC31QfqntCKtYNuNzl7J5nR nOVw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id cz15si795145edb.381.2020.04.28.01.29.12; Tue, 28 Apr 2020 01:29:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726884AbgD1IZW (ORCPT + 99 others); Tue, 28 Apr 2020 04:25:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33526 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726660AbgD1IZV (ORCPT ); Tue, 28 Apr 2020 04:25:21 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 44F4BC03C1AC for ; Tue, 28 Apr 2020 01:25:21 -0700 (PDT) Received: from dude02.hi.pengutronix.de ([2001:67c:670:100:1d::28] helo=dude02.lab.pengutronix.de) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jTLYD-0005oz-3B; Tue, 28 Apr 2020 10:25:09 +0200 Received: from mfe by dude02.lab.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1jTLYA-0003sR-0V; Tue, 28 Apr 2020 10:25:06 +0200 Date: Tue, 28 Apr 2020 10:25:05 +0200 From: Marco Felsch To: Maxime Ripard Cc: Robert Foss , Rob Herring , Dongchun Zhu , Fabio Estevam , Andy Shevchenko , Sakari Ailus , Tomasz Figa , linux-media , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-kernel , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" Subject: Re: [PATCH v7 1/3] media: dt-bindings: ov8856: Document YAML bindings Message-ID: <20200428082505.GA22489@pengutronix.de> References: <20200408110816.2712841-1-robert.foss@linaro.org> <20200408110816.2712841-2-robert.foss@linaro.org> <20200415160729.GA4438@bogus> <20200415162110.bmorj4u4hkqohqjx@pengutronix.de> <20200428075504.ovzugt2mbgan7z3k@gilmour.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200428075504.ovzugt2mbgan7z3k@gilmour.lan> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 10:23:30 up 66 days, 19:40, 148 users, load average: 0.03, 0.16, 0.38 User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::28 X-SA-Exim-Mail-From: mfe@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 20-04-28 09:55, Maxime Ripard wrote: > On Mon, Apr 27, 2020 at 05:13:42PM +0200, Robert Foss wrote: > > On Wed, 15 Apr 2020 at 18:21, Marco Felsch wrote: > > > > > > On 20-04-15 11:07, Rob Herring wrote: > > > > On Wed, Apr 08, 2020 at 01:08:14PM +0200, Robert Foss wrote: > > > > > From: Dongchun Zhu ... > > > > > + clock-names: > > > > > + description: > > > > > + Input clock for the sensor. > > > > > + items: > > > > > + - const: xvclk > > > > > + > > > > > + assigned-clocks: > > > > > + description: > > > > > + Input clock for the sensor. > > > > > + > > > > > + assigned-clock-rates: > > > > > + description: > > > > > + Frequency of the xvclk clock in Hertz. > > > > > > > > These 2 should have a 'maxItems: 1' > > > > > > Don't know why those properties are needed here.. IMHO this shouldn't be > > > part of the binding or at least it should be optional and not required. > > > All we need is the clocks and the clock-names property. > > > > Thanks Marco, I'll make it optional for the next revision. > > Well, the whole discussion we had was about removing them entirely? +1 from my side. It is part of the system integration and not part of this device. Regards, Marco > Maxime