Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200417073512.42350-1-yanaijie@huawei.com>
In-Reply-To: <20200417073512.42350-1-yanaijie@huawei.com>
From:   Linus Walleij <linus.walleij@linaro.org>
Date:   Tue, 28 Apr 2020 11:56:25 +0200
Message-ID: <CACRpkdaH1bet-iBxB7pM9-_swpXkuUiMeg6jwTyx2j8WiB2G_g@mail.gmail.com>
Subject: Re: [PATCH] pinctrl: nomadik: db8500: remove some unused symbols
To:     Jason Yan <yanaijie@huawei.com>
Cc:     Stephan Gerhold <stephan@gerhold.net>,
        Linux ARM <linux-arm-kernel@lists.infradead.org>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Hulk Robot <hulkci@huawei.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Apr 17, 2020 at 9:08 AM Jason Yan <yanaijie@huawei.com> wrote:

> Fix the following gcc warning:
>
> drivers/pinctrl/nomadik/pinctrl-nomadik-db8500.c:899:20: warning:
> =E2=80=98sbag_groups=E2=80=99 defined but not used [-Wunused-const-variab=
le=3D]
>  DB8500_FUNC_GROUPS(sbag, "sbag_oc2_1", "sbag_oc4_1");
>                     ^
> drivers/pinctrl/nomadik/pinctrl-nomadik-db8500.c:570:23: warning:
> =E2=80=98ipgpio6_c_2_pins=E2=80=99 defined but not used [-Wunused-const-v=
ariable=3D]
>  static const unsigned ipgpio6_c_2_pins[] =3D { DB8500_PIN_G3 };
>                        ^~~~~~~~~~~~~~~~
> drivers/pinctrl/nomadik/pinctrl-nomadik-db8500.c:472:23: warning:
> =E2=80=98mc1dir_a_1_pins=E2=80=99 defined but not used [-Wunused-const-va=
riable=3D]
>  static const unsigned mc1dir_a_1_pins[] =3D { DB8500_PIN_AH13,
> DB8500_PIN_AG12,
>                        ^~~~~~~~~~~~~~~
> drivers/pinctrl/nomadik/pinctrl-nomadik-db8500.c:453:23: warning:
> =E2=80=98modem_a_1_pins=E2=80=99 defined but not used [-Wunused-const-var=
iable=3D]
>  static const unsigned modem_a_1_pins[] =3D { DB8500_PIN_D22,
> DB8500_PIN_C23,
>                        ^~~~~~~~~~~~~~
> drivers/pinctrl/nomadik/pinctrl-nomadik-db8500.c:430:23: warning:
> =E2=80=98kpskaskb_a_1_pins=E2=80=99 defined but not used [-Wunused-const-=
variable=3D]
>  static const unsigned kpskaskb_a_1_pins[] =3D { DB8500_PIN_D17,
> DB8500_PIN_D16 };
>                        ^~~~~~~~~~~~~~~~~
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>

These should not be deleted but used properly. I've sent another
patch fixing the problem and adding you as Reported-by.

Yours,
Linus Walleij