Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp3959597ybz; Tue, 28 Apr 2020 03:22:13 -0700 (PDT) X-Google-Smtp-Source: APiQypKZna8L92hxMBeJLZf/vvBVy5a9c9Z31HwDsICZu1DuSzZasFh8KEUn8Y9c38OerLrSjPPJ X-Received: by 2002:a17:906:d968:: with SMTP id rp8mr10863156ejb.305.1588069333178; Tue, 28 Apr 2020 03:22:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588069333; cv=none; d=google.com; s=arc-20160816; b=vbBp/4S6VpGR2yXDcXcoHkTBTIs2p85TzYV1lYqSj8r0OQaPW4d1YvEoPOw3cXAR9X qvdF3KXUjZ1ZEehNgw3MFe5xQ/sfgkfmgS9NVo1m4QDNo9LbHoLmPoO5o1Qf1XVmGe9h vfm8KNLXje74aJb3eKkZaz+VUIo0wsfRtc6Tg5lb6E0AzFtOsAz9u7OOk8h+ipjpaDAC eWf/jSIBZN3SMlr5CZ1d/axisfjGDcSDSOktzWZ1Um8mwaLjVRiRQmrc+1iTCRsKX9aM HmjBcz1d2r+U4A9I7R69eTWvWXf4vL2NA7wdtrDtOD14oFVHGfIilBJnd/lHTrJ0YNR2 tM6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=7U5BWzMh2K40xw23VfK/WezdMP/Vkys+baeur7725L0=; b=g3hjZVvUOQbpnnfpr3x74pcGCbzWTFCYdXWKpmP+iCxXSkqGA6ze9Nly56qsenIX7k lWXDdkBF3ozImRDD8nHw8DSsWeJZiXgEbPelwMHbobtoUcinnRLZQyMYPvswwjvK3DMe 09OWwR6grALpR2jd5hEdBksFd/9HlJ+zLzSXpjHp9DF5lNw8Oc4VJhmO4ZV5MpgzfyxR nwYhY7JKx+Y6MPC6EXKo/R+hIT+kRR5tUk3AoXRLOHaq4sXFPVwpZ51HiT13q0/L87Cx kOQt4Na7sf3aUmaxtqTekpXA/FHb3/AaUYulpo6pW0Avh+jXFMN7gtugS7s1WDAxXdkz Xbyw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ga2si1635818ejb.210.2020.04.28.03.21.50; Tue, 28 Apr 2020 03:22:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727884AbgD1KUT (ORCPT + 99 others); Tue, 28 Apr 2020 06:20:19 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:38808 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727114AbgD1KUR (ORCPT ); Tue, 28 Apr 2020 06:20:17 -0400 Received: from 1.general.cking.uk.vpn ([10.172.193.212] helo=localhost) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1jTNLa-0002bp-1H; Tue, 28 Apr 2020 10:20:14 +0000 From: Colin King To: Nilesh Javali , GR-QLogic-Storage-Upstream@marvell.com, "James E . J . Bottomley" , "Martin K . Petersen" , Arun Easi , Himanshu Madhani , linux-scsi@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH][next] scsi: qla2xxx: make 1 bit bit-fields unsigned int Date: Tue, 28 Apr 2020 11:20:13 +0100 Message-Id: <20200428102013.1040598-1-colin.king@canonical.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Colin Ian King The bitfields mpi_fw_dump_reading and mpi_fw_dumped are currently signed which is not recommended as the representation is an implementation defined behaviour. Fix this by making the bit-fields unsigned ints. Fixes: cbb01c2f2f63 ("scsi: qla2xxx: Fix MPI failure AEN (8200) handling") Signed-off-by: Colin Ian King --- drivers/scsi/qla2xxx/qla_def.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_def.h b/drivers/scsi/qla2xxx/qla_def.h index daa9e936887b..172ea4e5887d 100644 --- a/drivers/scsi/qla2xxx/qla_def.h +++ b/drivers/scsi/qla2xxx/qla_def.h @@ -4248,8 +4248,8 @@ struct qla_hw_data { int fw_dump_reading; void *mpi_fw_dump; u32 mpi_fw_dump_len; - int mpi_fw_dump_reading:1; - int mpi_fw_dumped:1; + unsigned int mpi_fw_dump_reading:1; + unsigned int mpi_fw_dumped:1; int prev_minidump_failed; dma_addr_t eft_dma; void *eft; -- 2.25.1