Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp3977496ybz; Tue, 28 Apr 2020 03:41:16 -0700 (PDT) X-Google-Smtp-Source: APiQypKkkqWnguhw6YRi7Z6rL2LObyGkiSNvz7icVCEHElPNr4bXErPdZWPa9MKlXjk0W8lhhrck X-Received: by 2002:a17:906:b253:: with SMTP id ce19mr24981398ejb.341.1588070475952; Tue, 28 Apr 2020 03:41:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588070475; cv=none; d=google.com; s=arc-20160816; b=DBV+0jftfiar7M7Bxnll/gJE/475G6mN4ygC8Ix+OtDZHhwwj7ATR/QxdJE6+9N8hR o5gmZ/gvbMYLnaRPM7yga0DIUROUMeeICrpoEmM7b9qsBvY6ZexcY/zSM/HLKEbV7Uwu woeHs+0J7b6vCncuH47KngJypKRUJ8ZLlF0ahuMHEaVK5b/jcmecaD/j6+zz9chrASm5 mTh8vsroszzlRKTvaexcdqBdGywIV7SL/WbVhhCBkFwmpSI9QNybo50bU7fY/cbit9A4 C9Ih+E7Jgdy9r22zdkMpZrID8b8WNojywaU/u15AGJsOtXhr7VHLb0PD51movtluIl0/ NAbg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=80sgaI4V0GcoX09oHFdbjGz6NLLhGSyR/ATMNQ5JFUg=; b=0Vw+DpxXNhKbntn+PgqSaaitefvt5DcQ/SnavIBli9Bvc/C38VtTwn3HmJcdVVFpUr 1jrhhaXVt0fk3Ds1fiJ3CCnVifkKxvdgHrI0EJmesDNMAOjFtIkpIeG4DgIseHh39dD8 l3KRwHc/xv/q8iWGzptQMf7uoyhYiMNWkdY86Ds1k2fqG8WiGNCRNMMXi8jY4eaN2SuG TLAuWq7yng1vjPWQWwiofN4Er0B42GX/i6YiFb+6NnX1n3KXUXs8Hj+oFxjMkhdHl6mg RjQRWp1BeqHJWU14M0eVF1Ee2DldQs6NQ8YkP1cNZcR2/7wGy7rVjfE6hL9f5o5Ue81D zyiQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=KS7057pW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dd5si1400431edb.34.2020.04.28.03.40.52; Tue, 28 Apr 2020 03:41:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=KS7057pW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726335AbgD1Kj0 (ORCPT + 99 others); Tue, 28 Apr 2020 06:39:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54372 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726345AbgD1Kj0 (ORCPT ); Tue, 28 Apr 2020 06:39:26 -0400 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 02EF9C03C1AB for ; Tue, 28 Apr 2020 03:39:25 -0700 (PDT) Received: by mail-wr1-x442.google.com with SMTP id x17so23293282wrt.5 for ; Tue, 28 Apr 2020 03:39:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=80sgaI4V0GcoX09oHFdbjGz6NLLhGSyR/ATMNQ5JFUg=; b=KS7057pWE5Y3f6NX4Rf0u1UU51Wh7W5BrXh4bhGUOZ3N27k8Mna6+KeaRUL1/cew8A Zv65yxTYa5KCTTUXf77KIOfc4+o+qYsA1IaSdrNDJNfQYTM7AgG+byIIzsLahp2diQUp yi6kv4AKlOdjnY+i9SIaPtOCf2CWXf0rLQIYHl4yrR0ZVyHVo/G6nS1iFttdoZy79d8+ 7c2ruAgUCtMl+KCB+bCBYWwenNnWF+yOQlTSijHQCstZWYYmu3qq9fYhVJmuvBAn3frs unkxkzK4N3wV11/pc05dF5HwH80dG8t6dmllRox6fiF6ZOHt3/IikSRX0/c72nnebqgf M7yQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=80sgaI4V0GcoX09oHFdbjGz6NLLhGSyR/ATMNQ5JFUg=; b=e7kQ58I43zocG4lgz8RVsiV8lOsYQjvzbzJWXrbIk7/GigsXdpn4zQ6iUK0bnY2ngW B0o2R16rUZFA1GhyCQhfy738wBqz2kNdAHw/8vOfSFIFMtTVqrWKwQ3o+4W6ScxbWiat r/YkTrnY01Mt8pJlJx639lUMwTl+UrGH1WYWSNDNniHTrxdb5OhPvLRuACb1iHSuZRtx si11AH/QWY300fMlBaueJGDUhK6eRLuvcT4K+HWo+nR/FgLdiNjvlLC7RsPrwkelMmMZ lHi62c2zw7MsykgVy6JMLP3DXArNg+DnuzT1PjpRErhKQS1ZZYOWWyMQ9rKATSFHsn0Z qTEg== X-Gm-Message-State: AGi0Pub/XlQeKeuxQ0NhW8KHNxGmnobPMtyrOzSZ6iWXT/KIl/Mmul7p Q3aVjs0z2j4GoBJlUdsnH4pnaMC9Dkw= X-Received: by 2002:adf:ce0a:: with SMTP id p10mr31435246wrn.89.1588070364624; Tue, 28 Apr 2020 03:39:24 -0700 (PDT) Received: from dell ([2.31.163.63]) by smtp.gmail.com with ESMTPSA id y18sm2914896wmc.45.2020.04.28.03.39.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Apr 2020 03:39:24 -0700 (PDT) Date: Tue, 28 Apr 2020 11:39:22 +0100 From: Lee Jones To: Wei Yongjun Cc: Srinivas Kandagatla , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] mfd: wcd934x: Drop kfree for memory allocated with devm_kzalloc Message-ID: <20200428103922.GS3559@dell> References: <20200427110805.154447-1-weiyongjun1@huawei.com> <20200427122922.56643-1-weiyongjun1@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200427122922.56643-1-weiyongjun1@huawei.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 27 Apr 2020, Wei Yongjun wrote: > It's not necessary to free memory allocated with devm_kzalloc > and using kfree leads to a double free. > > Fixes: 6ac7e4d7ad70 ("mfd: wcd934x: Add support to wcd9340/wcd9341 codec") > Signed-off-by: Wei Yongjun > --- > drivers/mfd/wcd934x.c | 1 - > 1 file changed, 1 deletion(-) Applied, thanks. -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog