Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 28 Apr 2020 13:08:36 +0200
From:   Greg KH <gregkh@linuxfoundation.org>
To:     vladimir.stankovic@displaylink.com
Cc:     linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
        mausb-host-devel@displaylink.com
Subject: Re: [PATCH v5 7/8] usb: mausb_host: MA-USB PAL events processing
Message-ID: <20200428110836.GD1145239@kroah.com>
References: <20200327152614.26833-1-vladimir.stankovic@displaylink.com>
 <20200425091954.1610-1-vladimir.stankovic@displaylink.com>
 <20200425091954.1610-8-vladimir.stankovic@displaylink.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200425091954.1610-8-vladimir.stankovic@displaylink.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sat, Apr 25, 2020 at 11:19:53AM +0200, vladimir.stankovic@displaylink.com wrote:
> +static int mausb_device_assign_address(struct mausb_device *dev,
> +				       struct mausb_usb_device_ctx *usb_dev_ctx)
> +{
> +	int status =
> +		mausb_setusbdevaddress_event_to_user(dev,
> +						     usb_dev_ctx->dev_handle,
> +						     RESPONSE_TIMEOUT);
> +
> +	mausb_pr_info("dev_handle=%#x, status=%d", usb_dev_ctx->dev_handle,
> +		      status);

When drivers are working properly, they are totally silent.  Please
remove this type of debugging code from the driver entirely, or change
it to be dev_dbg().

Otherwise this really looks like a very noisy driver.

greg k-h