Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp4024340ybz; Tue, 28 Apr 2020 04:33:20 -0700 (PDT) X-Google-Smtp-Source: APiQypL8TCB3I2vE4qBuz8+IAiMwVDbluGgw88WsNPOwUgwlGbCtytwklDD6LbsaWFF/I+Z5O5Qq X-Received: by 2002:aa7:cc03:: with SMTP id q3mr22677112edt.131.1588073599884; Tue, 28 Apr 2020 04:33:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588073599; cv=none; d=google.com; s=arc-20160816; b=hyI2jYVg9uEuz4yKyWDYuEQ0saetVj9Br0akvdOjdDTrW14ED3XMjjHAesSCH0gCil HB0oa5tgvWnqxKaQYKaLSxizdqRubBVEumGlDQwHypYN+jrlicsQcAsToIe2vovlP0Os W4IbFWJgCAy8KX3VbxsdPwikCi4kVfPCQIIK3fZnnWY2U+5VR6cga9tVTITfEJrLtKZO 8QO4N9d2qESkljwMrgz75tBW2r6kQ4jHtMzq9TRk8STQG8LgVaVGOe8QUZ5keFz6Z5w1 UNbIy6dO4lHbzW5FsBvT7AGup+W4GNNQH0Oitsa1Iw4/B/avQGqvz2X+85qe7MreFhRa x0CQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=r1PsnQKSDcSsmqVQwSBJdVQVxo3xExX12GJ0iaQsulQ=; b=n+EzuwKIOYNy4ndTRIPE6Kh2UPVs6IWxmMJO+cQ1fMS3IobdmOyGd5TSZNBh0TDAbm kcXb9CvRKO6M+nIH43atdSzprFKvixkscVMyp8E/p+nBJBhVwbVaXb9loW4i/Gz8YqjC P5FcAKHjM7YTFuvBumuG/O3gLEx+178B1QjJPbwV8XdvhIm5qsF/POIw3uNlmmiDFFxP z//6uMkDkEFmRC2krkPtoBnS6uIqH9iMN8B7GSNVHH72VZDXXYDzDHNekmOHdpnLSdmX R2ukVu+j2SMYuc0vxfr9tZCCt/7a8zNDuj5W5W+QUnFCsgbtlAr1u6Fbo8673Hain6So jVbA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=QXN7mTgg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m18si1597374eja.298.2020.04.28.04.32.56; Tue, 28 Apr 2020 04:33:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=QXN7mTgg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726571AbgD1Lah (ORCPT + 99 others); Tue, 28 Apr 2020 07:30:37 -0400 Received: from mail.kernel.org ([198.145.29.99]:40382 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726419AbgD1Lag (ORCPT ); Tue, 28 Apr 2020 07:30:36 -0400 Received: from localhost (fw-tnat.cambridge.arm.com [217.140.96.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 99138206A1; Tue, 28 Apr 2020 11:30:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588073436; bh=bmn/QeL07kN6ZF+drWtdbMskzMxoYTgWWIqxwCRdXf4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=QXN7mTggzYM5iyN9EKtU2t26wDOabguc6BJyfL9I9ZktUFES2RtQ9TuYb3oSdKyGJ h9SKy7kOhvpYLmygqhauu4Ndgh/XXWktuuTitkA5oIm7y+SidIvmVZ/jNqIM4m5+sV /8R2NSjfbzEFBH4knAeFN8+52tqfm+s60t0W5LpM= Date: Tue, 28 Apr 2020 12:30:33 +0100 From: Mark Brown To: Leslie =?utf-8?B?SHNpYSjlpI/pgqbpgLJfUGVnYXRyb24p?= Cc: "knaack.h@gmx.de" , "lars@metafoo.de" , "pmeerw@pmeerw.net" , "linux-iio@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Hermes =?utf-8?B?SHNpZWgo6Kyd5pe75YqtX1BlZ2F0cm9uKQ==?= , "jesse.sung@canonical.com" , "jic23@kernel.org" Subject: Re: [PATCH] subsystem: Amplifier driver for TAS5805M,Texas instruments Message-ID: <20200428113033.GE5677@sirena.org.uk> References: <754706C925201D4896E92CCAD6B38E4401F0F733E3@PTW-EX-37.PEGA.CORP.PEGATRON> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="bi5JUZtvcfApsciF" Content-Disposition: inline In-Reply-To: <754706C925201D4896E92CCAD6B38E4401F0F733E3@PTW-EX-37.PEGA.CORP.PEGATRON> X-Cookie: Eschew obfuscation. User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --bi5JUZtvcfApsciF Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Apr 28, 2020 at 10:43:18AM +0000, Leslie Hsia(=E5=A4=8F=E9=82=A6=E9= =80=B2_Pegatron) wrote: > * Author: Leslie Hsia > * Amplifier driver for TAS5805M, initial the amplifier and set the so= und parameter. > * Signed-off-by: Leslie Hsia > Please follow the patch submission process that is described in Documentation/process/submitting-patches.rst in the kernel source. Take a look at other submissions on the list and follow a similar process. There also appear to be both IIO and ASoC drivers in there which is at best a bit weird. Having done a quick scan through your code it doesn't actually seem to integrate with the subsystem at all (there's no snd_soc_register_codec())=20 Please submit patches using subject lines reflecting the style for the subsystem, this makes it easier for people to identify relevant patches. Look at what existing commits in the area you're changing are doing and make sure your subject lines visually resemble what they're doing. There's no need to resubmit to fix this alone. --bi5JUZtvcfApsciF Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl6oE9gACgkQJNaLcl1U h9CBNwf9GnZKlT7pJP/Ffhe6NYK62tVJxbnR+kIljUUaRAdSQyXtO0R54DP6U890 CZoGgcrPIG+TYwY+mFJ29DaTKGVWGlkoXsEQi4kECGmKLKTH3lfY698eXGqJM4WZ TplTUGDbl1n08WOpqdLeX1XdEXM+LHqBAAG7KmNgk/MYFFnVN0QMADONgtAW/6SW vfyMttbzzRAOYGZ5wUsnL6+O1qShCElLKOzhcIj+3XDD+rt+iejwrq0hd1CUndWY Zd7ENnySP+KAtk4pYfr0UbjNzdSbKDnQgLEiRFNoCHizBF/+28O0PslkVKSgAjpQ 2TGhh2N0R+7r03DW5Kpuj7U6xxPZvQ== =n/8D -----END PGP SIGNATURE----- --bi5JUZtvcfApsciF--