Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200413155134.250243-1-purisame@spuri.io>
In-Reply-To: <20200413155134.250243-1-purisame@spuri.io>
From:   Dave Stevenson <dave.stevenson@raspberrypi.com>
Date:   Tue, 28 Apr 2020 13:49:40 +0100
Message-ID: <CAPY8ntAmdpB7xNYaunzxg8ZxguAyh+41U1KnyNC_w5OODU19sQ@mail.gmail.com>
Subject: Re: [PATCH] media: i2c: imx219: remove redundant writes
To:     Sameer Puri <purisame@spuri.io>
Cc:     Mauro Carvalho Chehab <mchehab@kernel.org>,
        Linux Media Mailing List <linux-media@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Sameer

Thanks for the patch.

On Mon, 13 Apr 2020 at 16:51, Sameer Puri <purisame@spuri.io> wrote:
>
> These writes to 0x162, 0x163 already appear earlier in the struct for
> the 1920x1080 mode and do not need to be repeated.
>
> Signed-off-by: Sameer Puri <purisame@spuri.io>

Reviewed-by: Dave Stevenson <dave.stevenson@raspberrypi.com>

If I was going to be fussy, it would be nice to have the writes to
0x162/0x163 in a consistent place in the table, which is generally the
end (I'm aware that the 640x480 mode has it in the middle). Personally
I'm not overly worried, but others may prefer it.

> ---
>  drivers/media/i2c/imx219.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/media/i2c/imx219.c b/drivers/media/i2c/imx219.c
> index cb03bdec1f9c..53dafb7f5f2c 100644
> --- a/drivers/media/i2c/imx219.c
> +++ b/drivers/media/i2c/imx219.c
> @@ -253,8 +253,6 @@ static const struct imx219_reg mode_1920_1080_regs[] = {
>         {0x4793, 0x10},
>         {0x4797, 0x0e},
>         {0x479b, 0x0e},
> -       {0x0162, 0x0d},
> -       {0x0163, 0x78},
>  };
>
>  static const struct imx219_reg mode_1640_1232_regs[] = {
>
> base-commit: 8f3d9f354286745c751374f5f1fcafee6b3f3136
> --
> 2.26.0
>
>