Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp4099999ybz; Tue, 28 Apr 2020 05:52:57 -0700 (PDT) X-Google-Smtp-Source: APiQypI/gm0trG5bPJzsEdArkrz/g60YmATVM7cnNbaSHo9KjGfNwVJXB79CzzjqAGZlkNVtXx6M X-Received: by 2002:a17:906:1dce:: with SMTP id v14mr12189250ejh.244.1588078376981; Tue, 28 Apr 2020 05:52:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588078376; cv=none; d=google.com; s=arc-20160816; b=dJ6y5kdaFnaJZ6VPwQfjlOrByb+yhHpSsrbFtePgADpCZK9QQYln3DgZAVDQc5cah8 E2Rsu+dWrP3bG1hnxAZk6eoCB0rxY93P75Z6N85HaII/lg89vRmCfD18+6XUzSpZfO9B JSAzTckQBlleiSC12p8fAJV+XESa8ai641tyDYDmm17j527t0zfXunX+odEWYYXduJDA 7fkUmwXbtveoIMMGfimo4FTnyfx/rggwOl3CT24N0dqg/mO7JJf9qyEJYy/cpiKSVv96 rxFjhJgdhl1+JMQM+2qUKLiN85C0/d+j0wmLbLas/FghrlNTnXkb9q1k3GpP4DTUc6up RBEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:organization:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:ironport-sdr:ironport-sdr; bh=E/j6NKXQo/QD2AR5dbfaCvEozC67C1Mopyr4Sn5jhxM=; b=V5o5R95aRZPKKl3zZBkAoi8/I1f4gv1oRKdQ7RpOyNl12eymHLdATuX8bmHUF+b3eN 2GFzow1s0YqkxWXZF4j6FFNrOHufZaGB2xZy3hXaFOR+LLOVQycujD+e5HWHql95CK7Q ZzxT6ouZx3WKdJaMFGCr2Vtb3ajeHCvfRkFDx7fi2xx/+EylYhqAP3K5U8I1RHlmoLRd eAqBm5erappPywXU3kL/p1/Gs/uO2/N82FRI4tgdGGDVlUw4TJ0tVVFJzbg8xkzT0NK8 +ESOuZ/AyjrDOLxImx6SgArm1FVO7n1aSV7R76zmBBVf/8Lq2828dMQsQgBg3tNj2Q+b 9k8A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o4si1555099edb.178.2020.04.28.05.52.33; Tue, 28 Apr 2020 05:52:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727083AbgD1Muz (ORCPT + 99 others); Tue, 28 Apr 2020 08:50:55 -0400 Received: from mga18.intel.com ([134.134.136.126]:54668 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727071AbgD1Mux (ORCPT ); Tue, 28 Apr 2020 08:50:53 -0400 IronPort-SDR: 1rgqmyF9lNl2HI94eQaItmlRhjx/XyFIfLfHwvOOC4hprRprkUAMequgZnX9YTBmoYifi+FVUR WdVifkj72xkA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Apr 2020 05:50:52 -0700 IronPort-SDR: SCQqSllUydQSHNN+qQ7dk5wAut5zz6fYbhReVhnikxqFFMRrSYFI7FjQSqPzVDIbL7k/3aJrl1 wfTwI3PK4ZWA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,327,1583222400"; d="scan'208";a="292845050" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga002.fm.intel.com with ESMTP; 28 Apr 2020 05:50:47 -0700 Received: from andy by smile with local (Exim 4.93) (envelope-from ) id 1jTPhJ-003YnF-8d; Tue, 28 Apr 2020 15:50:49 +0300 Date: Tue, 28 Apr 2020 15:50:49 +0300 From: Andy Shevchenko To: Michael Walle Cc: linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-pwm@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Linus Walleij , Bartosz Golaszewski , Rob Herring , Jean Delvare , Guenter Roeck , Lee Jones , Thierry Reding , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Wim Van Sebroeck , Shawn Guo , Li Yang , Thomas Gleixner , Jason Cooper , Marc Zyngier , Mark Brown , Greg Kroah-Hartman Subject: Re: [PATCH v3 05/16] mfd: Add support for Kontron sl28cpld management controller Message-ID: <20200428125049.GU185537@smile.fi.intel.com> References: <20200423174543.17161-1-michael@walle.cc> <20200423174543.17161-6-michael@walle.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200423174543.17161-6-michael@walle.cc> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 23, 2020 at 07:45:32PM +0200, Michael Walle wrote: > This patch adds core support for the board management controller found > on the SMARC-sAL28 board. It consists of the following functions: > - watchdog > - GPIO controller > - PWM controller > - fan sensor > - interrupt controller ... > obj-$(CONFIG_MFD_STMFX) += stmfx.o > > obj-$(CONFIG_SGI_MFD_IOC3) += ioc3.o > + > +obj-$(CONFIG_MFD_SL28CPLD) += sl28cpld.o Perhaps keep an order? ... > + return devm_mfd_add_devices(dev, -1, sl28cpld_devs, -1 has its own definition. > + ARRAY_SIZE(sl28cpld_devs), NULL, > + i2c->irq, NULL); > +} -- With Best Regards, Andy Shevchenko