Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp4166323ybz; Tue, 28 Apr 2020 06:53:09 -0700 (PDT) X-Google-Smtp-Source: APiQypIdHfveJgCnpaZnCbiPfbKmVZM81R8vsWYclVw546G/3HLsxGigKDvV26iRrGKxVoMzxzS+ X-Received: by 2002:a05:6402:204e:: with SMTP id bc14mr23590738edb.199.1588081989660; Tue, 28 Apr 2020 06:53:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588081989; cv=none; d=google.com; s=arc-20160816; b=lmnyXC4b0nZswyceZj8Js2HWwLt/EfKVvNsWjbAHgpnSDXacd/FOIii0cqueaSMyAO juzcAhEI2eHd6/qN4FwHUpBKf/bL/UqaXEFFQYlsl7G7smPltW090KBVEL98oyeUNOx7 7rrWMPpa6MqI/gL2GKcNOwu6rDa+XEuEVxlkOLTnndTIl+zLl2BkFaYDZ2pSwnKOcE4e hrgSAkUKAOHlEGelxKo3WTWxvDmlmcVODI5o8Ge5MY1JCVHNRPyQKH+w8pY6KG3DFecK iS0FyExLZew4q+R+TwCcGRBSbzuovJmFmBXLEvmiaRiDySlF80Fzh+tPg7COlE/pt9od 7Xow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=hprmAywS78pYBC0BQt7gTceIcUivP3JeOHfXgeteKA0=; b=IOIIqS0L3dQawKnglDrON3OBQ/yunh/8NBFsAExnYw1PTSPaZcpLqqDyUbxrysZcEI TUgsb14kAvcVEpPjKM3zIGzdyfmhqsneGn5qdEt/rF+okp5mhkqNEqd67PsiETfC2hI4 ZIeIyC/AvVi1HmNOIYJeM2Q9COJbAqCqd2RqT2jzm61ZcW5ov7KvcpTx/3WhbBbFXJB8 ssqzaeOXaTtgBNA0WVyXBWSvtZbozYhiB3lmmcQ3yYva3RPzBrgWzGTyz1nawATGsW2X zMEVn4ozo/x2lcABtAwJ5nnDHLzruce/AjROsKXx0bn7aGVaSkrWm0zzrgyRYo6pWzhm ed1g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="fCPifXw/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 1si1928865ejx.68.2020.04.28.06.52.46; Tue, 28 Apr 2020 06:53:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="fCPifXw/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727828AbgD1NtA (ORCPT + 99 others); Tue, 28 Apr 2020 09:49:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55982 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727811AbgD1Ns7 (ORCPT ); Tue, 28 Apr 2020 09:48:59 -0400 Received: from mail-lj1-x241.google.com (mail-lj1-x241.google.com [IPv6:2a00:1450:4864:20::241]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 34CC2C03C1A9 for ; Tue, 28 Apr 2020 06:48:59 -0700 (PDT) Received: by mail-lj1-x241.google.com with SMTP id l19so21536146lje.10 for ; Tue, 28 Apr 2020 06:48:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=hprmAywS78pYBC0BQt7gTceIcUivP3JeOHfXgeteKA0=; b=fCPifXw/aNPOXfO0rsjZ+yaZg41307Lkkk7BSKaH5H7psRRpteV5LYlsmB0N4dqM+G B8ufwhgl1jAKHJtIaK2N3pMI8gNruYVHB2STb08rGaoYD52IUxGOz4Aspg3Ds0Le0ikd TVuF6fV3Rvf7ebyZClOq1W3RpoHzm1YWMlrNqWKruL5OMdAZDou+zZlYEpF0HNAI/2Mc 4NeZzLtbfLNep4qlhJEL6P9PCgYdG7lyL4tYiZmCwJhcQwNzV22+w6k7VeKjtO6YFRXV VYcgB+OPVwmv8eRYthKbSjqUsDGLqzpfUOeRl8laT2tDQSpAHIW/c8WTecXhOlyjnf/2 XtVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hprmAywS78pYBC0BQt7gTceIcUivP3JeOHfXgeteKA0=; b=mD0+F0YWogfPU8w0uaAig9oh+oQ6gL0pkSOXXb3eiQv4KniIO3bobwzvGGPXUvfGbZ y0QSI0ZrIr/6JiJvp7UlvfbBkYKliJZBPt84sywgg+oihUqeDAEjsOIyVgmvMi8gdPf9 MAZvQZj2UL8iZGH4Z5jWV3rO7wkXrODmYSP+905ArLzSf6wYE2ZzEd/o8j5oTBwDTV4c KSz3mpWhaKNPCruRXkXGVIp758Mxw0av2We7LxsIQc0gqm8B5Og7jjAS8qIOWYkh0bw0 7aLo7uxC9lyWD+9jmdiuh1boN5lwyMucKo1cvlSiRBfCRmtjJbp/hUWlPVaxIELc4qG5 1z4Q== X-Gm-Message-State: AGi0PuZxrwi1WsKgk5sbnPNjYlvFegqMYBh7QbntjyO/Qn1U/3acti73 u2Zo+F8ayvAxMiBfkoEo/JgwdEUv8DOYaOulBmAooQ== X-Received: by 2002:a05:651c:1058:: with SMTP id x24mr18355448ljm.39.1588081737490; Tue, 28 Apr 2020 06:48:57 -0700 (PDT) MIME-Version: 1.0 References: <20200424141432.11400-1-geert+renesas@glider.be> In-Reply-To: <20200424141432.11400-1-geert+renesas@glider.be> From: Linus Walleij Date: Tue, 28 Apr 2020 15:48:46 +0200 Message-ID: Subject: Re: [PATCH] gpiolib: Improve kernel messages To: Geert Uytterhoeven Cc: Bartosz Golaszewski , "open list:GPIO SUBSYSTEM" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 24, 2020 at 4:14 PM Geert Uytterhoeven wrote: > Simplify the printing of kernel messages and make the messages more > accurate by using the most appropriate {dev,chip,gpiod}_*() helpers. > > Sample impact: > > -gpiochip_setup_dev: registered GPIOs 496 to 511 on device: gpiochip0 (e6050000.gpio) > +gpio gpiochip0: registered GPIOs 496 to 511 on e6050000.gpio > > -no flags found for gpios > +gpio-953 (?): no flags found for gpios > > -GPIO line 355 (PCIE/SATA switch) hogged as output/low > +gpio-355 (PCIE/SATA switch): hogged as output/low > > Signed-off-by: Geert Uytterhoeven Patch applied. Yours, Linus Walleij