Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: /74rwQnrjotUXmDSSHPMkq3HGA+2Snwij6E047qaHy1ZXISuL0w13MlSuJMLEbnlFqw0ArDLgZ
 CB/UZ/E7dOcQ==
IronPort-SDR: a32MKs1Vc4Ev+5F+oxdlzBOXniz5YLkYcl5nVoILGCbw18YTPY7day0GsxsDV7PMwMEoh9s9rX
 r1jtTbxK5XnA==
Subject: Re: [PATCH] firmware: stratix10-svc: Drop unnecessary checking for
 and populating /firmware/ node
To:     Sudeep Holla <sudeep.holla@arm.com>
Cc:     linux-kernel@vger.kernel.org
References: <20200421173256.34897-1-sudeep.holla@arm.com>
 <8ca3666f-8ff1-3c3c-d40b-81c024b37bdd@linux.intel.com>
 <20200423081149.GB18538@bogus>
 <2b2e29ec-ebbf-3ee6-acc9-3722a2fabbfb@linux.intel.com>
 <20200428083238.GA21288@bogus>
From:   Richard Gong <richard.gong@linux.intel.com>
Message-ID: <a583b842-585d-888e-49e5-32a16dfab8a6@linux.intel.com>
Date:   Tue, 28 Apr 2020 09:14:25 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.9.0
MIME-Version: 1.0
In-Reply-To: <20200428083238.GA21288@bogus>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi,

On 4/28/20 3:32 AM, Sudeep Holla wrote:
> On Mon, Apr 27, 2020 at 02:12:56PM -0500, Richard Gong wrote:
>> Hi Sudeep,
>>
>> In our dts, firmware is not under root node. You can refer to
>> arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi for details.
>>
>> This is why we need check and populate firmware node.
>>
> 
> Ah that's bad. One of very few DTS I see firmware node not in the root.Per the Devicetree Specification, there is no need to define firmware 
under the root node. Some examples are fsl-ls1012a.dtsi and 
hi6220-hikey.dts.

> But this driver is the only one duplicating the codethen Commit 3aa0582fdb82 should be extended to handle firmware which is 
not defined under the root node. I am not sure if it is doable.
>
Regards,
Richard